feat!: remove custom header settings

Author: jsnwesson

src/containers/LearnerDashboardHeader/LearnerDashboardMenu.jsx

@@ -3,59 +3,7 @@
 exports[`LearnerDashboardHeader render 1`] = `
 <Fragment>
   <ConfirmEmailBanner />
-  <Header
-    mainMenuItems={
-      [
-        {
-          "content": "Courses",
-          "href": "/",
-          "isActive": true,
-          "type": "item",
-        },
-        {
-          "content": "Discover New",
-          "href": "http://localhost:18000/course-search-url",
-          "onClick": [Function],
-          "type": "item",
-        },
-      ]
-    }
-    secondaryMenuItems={[]}
-    userMenuItems={
-      [
-        {
-          "heading": "",
-          "items": [
-            {
-              "content": "Profile",
-              "href": "http://account-profile-url.test/u/undefined",
-              "type": "item",
-            },
-            {
-              "content": "Account",
-              "href": "http://account-settings-url.test",
-              "type": "item",
-            },
-            {
-              "content": "Order History",
-              "href": "test-url",
-              "type": "item",
-            },
-          ],
-        },
-        {
-          "heading": "",
-          "items": [
-            {
-              "content": "Sign Out",
-              "href": "http://localhost:18000/logout",
-              "type": "item",
-            },
-          ],
-        },
-      ]
-    }
-  />
+  <Header />
   <MasqueradeBar />
 </Fragment>
 `;

src/containers/LearnerDashboardHeader/__snapshots__/index.test.jsx.snap

@@ -1,43 +1,16 @@
 import React from 'react';
 
-import MasqueradeBar from 'containers/MasqueradeBar';
-import { AppContext } from '@edx/frontend-platform/react';
 import Header from '@edx/frontend-component-header';
-import { reduxHooks } from 'hooks';
-import urls from 'data/services/lms/urls';
-
+import MasqueradeBar from 'containers/MasqueradeBar';
 import ConfirmEmailBanner from './ConfirmEmailBanner';
 
-import { useLearnerDashboardHeaderMenu, findCoursesNavClicked } from './hooks';
-
-import './index.scss';
-
-export const LearnerDashboardHeader = () => {
-  const { authenticatedUser } = React.useContext(AppContext);
-  const { courseSearchUrl } = reduxHooks.usePlatformSettingsData();
-
-  const exploreCoursesClick = () => {
-    findCoursesNavClicked(urls.baseAppUrl(courseSearchUrl));
-  };
-
-  const learnerHomeHeaderMenu = useLearnerDashboardHeaderMenu({
-    courseSearchUrl,
-    authenticatedUser,
-    exploreCoursesClick,
-  });
-
-  return (
-    <>
-      <ConfirmEmailBanner />
-      <Header
-        mainMenuItems={learnerHomeHeaderMenu.mainMenu}
-        secondaryMenuItems={learnerHomeHeaderMenu.secondaryMenu}
-        userMenuItems={learnerHomeHeaderMenu.userMenu}
-      />
-      <MasqueradeBar />
-    </>
-  );
-};
+export const LearnerDashboardHeader = () => (
+  <>
+    <ConfirmEmailBanner />
+    <Header />
+    <MasqueradeBar />
+  </>
+);
 
 LearnerDashboardHeader.propTypes = {};
 

src/containers/LearnerDashboardHeader/hooks.js

@@ -1,52 +1,18 @@
-import { mergeConfig } from '@edx/frontend-platform';
 import { shallow } from '@edx/react-unit-test-utils';
 import Header from '@edx/frontend-component-header';
 
-import urls from 'data/services/lms/urls';
 import LearnerDashboardHeader from '.';
-import { findCoursesNavClicked } from './hooks';
 
-jest.mock('hooks', () => ({
-  reduxHooks: {
-    usePlatformSettingsData: jest.fn(() => ({
-      courseSearchUrl: '/course-search-url',
-    })),
-  },
-}));
-jest.mock('./hooks', () => ({
-  ...jest.requireActual('./hooks'),
-  findCoursesNavClicked: jest.fn(),
-}));
 jest.mock('containers/MasqueradeBar', () => 'MasqueradeBar');
 jest.mock('./ConfirmEmailBanner', () => 'ConfirmEmailBanner');
 jest.mock('@edx/frontend-component-header', () => 'Header');
 
 describe('LearnerDashboardHeader', () => {
   test('render', () => {
-    mergeConfig({ ORDER_HISTORY_URL: 'test-url' });
     const wrapper = shallow(<LearnerDashboardHeader />);
     expect(wrapper.snapshot).toMatchSnapshot();
     expect(wrapper.instance.findByType('ConfirmEmailBanner')).toHaveLength(1);
     expect(wrapper.instance.findByType('MasqueradeBar')).toHaveLength(1);
     expect(wrapper.instance.findByType(Header)).toHaveLength(1);
-    wrapper.instance.findByType(Header)[0].props.mainMenuItems[1].onClick();
-    expect(findCoursesNavClicked).toHaveBeenCalledWith(urls.baseAppUrl('/course-search-url'));
-    expect(wrapper.instance.findByType(Header)[0].props.secondaryMenuItems.length).toBe(0);
-  });
-
-  test('should display Help link if SUPPORT_URL is set', () => {
-    mergeConfig({ SUPPORT_URL: 'http://localhost:18000/support' });
-    const wrapper = shallow(<LearnerDashboardHeader />);
-    expect(wrapper.instance.findByType(Header)[0].props.secondaryMenuItems.length).toBe(1);
-  });
-  test('should display Programs link if it is enabled by configuration', () => {
-    mergeConfig({ ENABLE_PROGRAMS: true });
-    const wrapper = shallow(<LearnerDashboardHeader />);
-    expect(wrapper.instance.findByType(Header)[0].props.mainMenuItems.length).toBe(3);
-  });
-  test('should not display Discover New tab if it is disabled by configuration', () => {
-    mergeConfig({ NON_BROWSABLE_COURSES: true });
-    const wrapper = shallow(<LearnerDashboardHeader />);
-    expect(wrapper.instance.findByType(Header)[0].props.mainMenuItems.length).toBe(2);
   });
 });