Skip to content

Commit 5562d8a

Browse files
chore: Clean up learnerDashboardHeader files (#614)
1 parent a919426 commit 5562d8a

File tree

6 files changed

+11
-142
lines changed

6 files changed

+11
-142
lines changed

src/containers/LearnerDashboardHeader/BrandLogo.jsx

Lines changed: 0 additions & 27 deletions
This file was deleted.

src/containers/LearnerDashboardHeader/BrandLogo.test.jsx

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/containers/LearnerDashboardHeader/__snapshots__/BrandLogo.test.jsx.snap

Lines changed: 0 additions & 27 deletions
This file was deleted.
Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,53 +1,27 @@
11
import React from 'react';
2-
import { useWindowSize, breakpoints } from '@openedx/paragon';
32
import { useIntl } from '@edx/frontend-platform/i18n';
43
import track from 'tracking';
54
import { StrictDict } from 'utils';
65
import { linkNames } from 'tracking/constants';
76

87
import getLearnerHeaderMenu from './LearnerDashboardMenu';
98

10-
import * as module from './hooks';
11-
129
export const state = StrictDict({
1310
isOpen: (val) => React.useState(val), // eslint-disable-line
1411
});
1512

16-
export const useIsCollapsed = () => {
17-
const { width } = useWindowSize();
18-
const isCollapsed = React.useMemo(() => (width <= breakpoints.large.minWidth), [width]);
19-
return isCollapsed;
20-
};
21-
2213
export const findCoursesNavClicked = (href) => track.findCourses.findCoursesClicked(href, {
2314
linkName: linkNames.learnerHomeNavExplore,
2415
});
2516

26-
export const findCoursesNavDropdownClicked = (href) => track.findCourses.findCoursesClicked(href, {
27-
linkName: linkNames.learnerHomeNavDropdownExplore,
28-
});
29-
3017
export const useLearnerDashboardHeaderMenu = ({
3118
courseSearchUrl, authenticatedUser, exploreCoursesClick,
3219
}) => {
3320
const { formatMessage } = useIntl();
3421
return getLearnerHeaderMenu(formatMessage, courseSearchUrl, authenticatedUser, exploreCoursesClick);
3522
};
3623

37-
export const useLearnerDashboardHeaderData = () => {
38-
const [isOpen, setIsOpen] = module.state.isOpen(false);
39-
const toggleIsOpen = () => setIsOpen(!isOpen);
40-
41-
return {
42-
isOpen,
43-
toggleIsOpen,
44-
};
45-
};
46-
4724
export default {
48-
useIsCollapsed,
4925
findCoursesNavClicked,
50-
findCoursesNavDropdownClicked,
51-
useLearnerDashboardHeaderData,
5226
useLearnerDashboardHeaderMenu,
5327
};
Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { useWindowSize, breakpoints } from '@openedx/paragon';
21
import track from 'tracking';
32
import { linkNames } from 'tracking/constants';
43

@@ -9,10 +8,7 @@ import * as hooks from './hooks';
98
const state = new MockUseState(hooks);
109

1110
const {
12-
useIsCollapsed,
1311
findCoursesNavClicked,
14-
findCoursesNavDropdownClicked,
15-
useLearnerDashboardHeaderData,
1612
useLearnerDashboardHeaderMenu,
1713
} = hooks;
1814

@@ -29,17 +25,6 @@ describe('LearnerDashboardHeader hooks', () => {
2925
state.testGetter(state.keys.isOpen);
3026
});
3127

32-
describe('useIsCollapsed', () => {
33-
test('large screen is not collapsed', () => {
34-
useWindowSize.mockReturnValueOnce({ width: breakpoints.large.minWidth + 1 });
35-
expect(useIsCollapsed()).toEqual(false);
36-
});
37-
test('small screen is collapsed', () => {
38-
useWindowSize.mockReturnValueOnce({ width: breakpoints.large.minWidth - 1 });
39-
expect(useIsCollapsed()).toEqual(true);
40-
});
41-
});
42-
4328
describe('findCoursesNavClicked', () => {
4429
test('calls tracking with nav link name', () => {
4530
findCoursesNavClicked(url);
@@ -59,23 +44,4 @@ describe('LearnerDashboardHeader hooks', () => {
5944
expect(learnerHomeHeaderMenu.mainMenu.length).toBe(2);
6045
});
6146
});
62-
63-
describe('findCoursesNavDropdownClicked', () => {
64-
test('calls tracking with dropdown link name', () => {
65-
findCoursesNavDropdownClicked(url);
66-
expect(track.findCourses.findCoursesClicked).toHaveBeenCalledWith(url, {
67-
linkName: linkNames.learnerHomeNavDropdownExplore,
68-
});
69-
});
70-
});
71-
72-
describe('useLearnerDashboardHeaderData', () => {
73-
test('default state', () => {
74-
state.mock();
75-
const out = useLearnerDashboardHeaderData();
76-
state.expectInitializedWith(state.keys.isOpen, false);
77-
out.toggleIsOpen();
78-
expect(state.values.isOpen).toEqual(true);
79-
});
80-
});
8147
});

src/data/redux/requests/reducer.test.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,16 @@ describe('requests reducer', () => {
4747
});
4848
});
4949
});
50+
describe('clearRequest', () => {
51+
it('cleanup status and error', () => {
52+
expect(reducer(
53+
testingState,
54+
actions.clearRequest({ requestKey: testKey, error: testValue }),
55+
)).toEqual({
56+
...testingState,
57+
[testKey]: {},
58+
});
59+
});
60+
});
5061
});
5162
});

0 commit comments

Comments
 (0)