Skip to content

Commit abae82b

Browse files
authored
fix: remove remaining UpgradeButton definition and tests (#548)
1 parent 777d3aa commit abae82b

File tree

3 files changed

+3
-76
lines changed

3 files changed

+3
-76
lines changed

src/containers/CourseCard/components/CourseCardActions/UpgradeButton.jsx

Lines changed: 0 additions & 45 deletions
This file was deleted.

src/containers/CourseCard/components/CourseCardActions/index.test.jsx

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { shallow } from '@edx/react-unit-test-utils';
33
import { reduxHooks } from 'hooks';
44

55
import CourseCardActionSlot from 'plugin-slots/CourseCardActionSlot';
6-
import UpgradeButton from './UpgradeButton';
76
import SelectSessionButton from './SelectSessionButton';
87
import BeginCourseButton from './BeginCourseButton';
98
import ResumeButton from './ResumeButton';
@@ -21,7 +20,6 @@ jest.mock('hooks', () => ({
2120
}));
2221

2322
jest.mock('plugin-slots/CourseCardActionSlot', () => 'CustomActionButton');
24-
jest.mock('./UpgradeButton', () => 'UpgradeButton');
2523
jest.mock('./SelectSessionButton', () => 'SelectSessionButton');
2624
jest.mock('./ViewCourseButton', () => 'ViewCourseButton');
2725
jest.mock('./BeginCourseButton', () => 'BeginCourseButton');
@@ -59,19 +57,7 @@ describe('CourseCardActions', () => {
5957
});
6058
});
6159
describe('output', () => {
62-
describe('Exec Ed course', () => {
63-
it('does not render upgrade button', () => {
64-
mockHooks({ isExecEd2UCourse: true });
65-
render();
66-
expect(el.instance.findByType(UpgradeButton).length).toEqual(0);
67-
});
68-
});
6960
describe('entitlement course', () => {
70-
it('does not render upgrade button', () => {
71-
mockHooks({ isEntitlement: true });
72-
render();
73-
expect(el.instance.findByType(UpgradeButton).length).toEqual(0);
74-
});
7561
it('renders ViewCourseButton if fulfilled', () => {
7662
mockHooks({ isEntitlement: true, isFulfilled: true });
7763
render();
@@ -83,30 +69,23 @@ describe('CourseCardActions', () => {
8369
expect(el.instance.findByType(SelectSessionButton)[0].props.cardId).toEqual(cardId);
8470
});
8571
});
86-
describe('verified course', () => {
87-
it('does not render upgrade button', () => {
88-
mockHooks({ isVerified: true });
89-
render();
90-
expect(el.instance.findByType(UpgradeButton).length).toEqual(0);
91-
});
92-
});
9372
describe('not entitlement, verified, or exec ed', () => {
94-
it('renders UpgradeButton and ViewCourseButton for archived courses', () => {
73+
it('renders CourseCardActionSlot and ViewCourseButton for archived courses', () => {
9574
mockHooks({ isArchived: true });
9675
render();
9776
expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId);
9877
expect(el.instance.findByType(ViewCourseButton)[0].props.cardId).toEqual(cardId);
9978
});
10079
describe('unstarted courses', () => {
101-
it('renders UpgradeButton and BeginCourseButton', () => {
80+
it('renders CourseCardActionSlot and BeginCourseButton', () => {
10281
mockHooks();
10382
render();
10483
expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId);
10584
expect(el.instance.findByType(BeginCourseButton)[0].props.cardId).toEqual(cardId);
10685
});
10786
});
10887
describe('active courses (started, and not archived)', () => {
109-
it('renders UpgradeButton and ResumeButton', () => {
88+
it('renders CourseCardActionSlot and ResumeButton', () => {
11089
mockHooks({ hasStarted: true });
11190
render();
11291
expect(el.instance.findByType(CourseCardActionSlot)[0].props.cardId).toEqual(cardId);

src/tracking/trackers/course.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,6 @@ import { createEventTracker, createLinkTracker } from 'data/services/segment/uti
22
import { categories, eventNames } from '../constants';
33
import * as module from './course';
44

5-
export const upsellOptions = {
6-
linkName: 'course_dashboard_green',
7-
linkType: 'button',
8-
pageName: 'course_dashboard',
9-
linkCategory: 'green_update',
10-
};
11-
125
// Utils/Helpers
136
/**
147
* Generate a segement event tracker for a given course event.

0 commit comments

Comments
 (0)