Skip to content

[DEPR] feat!: remove notices wrapper#731

Merged
MaxFrank13 merged 5 commits intoopenedx:masterfrom
edx:mfrank/remove-notices-wrapper
Nov 13, 2025
Merged

[DEPR] feat!: remove notices wrapper#731
MaxFrank13 merged 5 commits intoopenedx:masterfrom
edx:mfrank/remove-notices-wrapper

Conversation

@MaxFrank13
Copy link
Member

@MaxFrank13 MaxFrank13 commented Oct 9, 2025

Removes NoticesWrapper in it's entirety

Resolves #692

@MaxFrank13 MaxFrank13 changed the title feat!: remove notices wrapper [DEPR] feat!: remove notices wrapper Oct 9, 2025
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (c38e805) to head (2abd407).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   97.60%   97.54%   -0.06%     
==========================================
  Files         152      148       -4     
  Lines        1334     1302      -32     
  Branches      231      225       -6     
==========================================
- Hits         1302     1270      -32     
  Misses         31       31              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaxFrank13 MaxFrank13 marked this pull request as ready for review November 10, 2025 14:53
@MaxFrank13
Copy link
Member Author

@arbrandes This is ready for review now that Ulmo has been cut

@MaxFrank13
Copy link
Member Author

Codecov Report

✅ All modified and coverable lines are covered by tests. ✅ Project coverage is 97.54%. Comparing base (b926e13) to head (311adfc).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   97.60%   97.54%   -0.06%     
==========================================
  Files         152      148       -4     
  Lines        1334     1302      -32     
  Branches      232      224       -8     
==========================================
- Hits         1302     1270      -32     
  Misses         31       31              
  Partials        1        1              

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

Code coverage is failing because I removed code

Copy link
Member

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good cleanup!

@MaxFrank13 MaxFrank13 merged commit 86b6574 into openedx:master Nov 13, 2025
5 of 6 checks passed
@MaxFrank13 MaxFrank13 deleted the mfrank/remove-notices-wrapper branch November 13, 2025 17:19
MaxFrank13 added a commit to edx/frontend-app-learner-dashboard that referenced this pull request Dec 11, 2025
…se-ulmo (#8)

* fix: Run `npm audit fix` to update dependencies.

* chore(deps): update dependency @openedx/paragon to v23.14.9 (openedx#735)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @reduxjs/toolkit to v2.9.1 (openedx#736)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump actions/setup-node from 5 to 6 (openedx#737)

* chore(deps): update dependency @edx/frontend-component-footer to v14.9.3 (openedx#739)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @edx/frontend-platform to v8.5.2 (openedx#740)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @reduxjs/toolkit to v2.9.2 (openedx#741)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @openedx/paragon to v23.16.0 (openedx#742)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @reduxjs/toolkit to v2.10.1 (openedx#743)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @edx/frontend-component-header to v8 (openedx#744)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* [DEPR] feat!: remove notices wrapper (openedx#731)

* fix(deps): update dependency react-router-dom to v6.30.2 (openedx#745)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @openedx/paragon to v23.17.0 (openedx#746)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @openedx/paragon to v23.18.0 (openedx#748)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @reduxjs/toolkit to v2.11.0 (openedx#749)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat: added  the ability for instances to use local translations  from extra repositories (openedx#752)

* feat: added  the ability for instances to use local translations  from extra repositories (openedx#752)

---------

Co-authored-by: Feanil Patel <feanil@axim.org>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ejaz Ahmad <86868918+jajjibhai008@users.noreply.github.com>
jignaciopm pushed a commit to eduNEXT/frontend-app-learner-dashboard that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[DEPR]: Learner Dashboard Notices

2 participants