fix: enroll button doesn't show up for customer with B&R budget + Codes (#1401)

Author: ahmad-hassan-dev

src/components/course/course-header/deprecated/CourseRunCard.jsx

@@ -21,6 +21,7 @@ import {
   useCanUserRequestSubsidyForCourse,
   useCourseEnrollmentUrl,
   useUserHasSubsidyRequestForCourse,
+  useUserHasLearnerCreditRequestForCourse,
   useUserSubsidyApplicableToCourse,
 } from '../../data/hooks';
 import { determineEnrollmentType } from '../../enrollment/utils';
@@ -84,6 +85,7 @@ const CourseRunCard = ({
   const { userSubsidyApplicableToCourse } = useUserSubsidyApplicableToCourse();
 
   const userHasSubsidyRequestForCourse = useUserHasSubsidyRequestForCourse(courseKey);
+  const userHasLearnerCreditRequest = useUserHasLearnerCreditRequestForCourse(courseKey, ['requested']);
 
   const sku = useMemo(
     () => findHighestLevelSku({ seats, courseEntitlements }),
@@ -104,6 +106,7 @@ const CourseRunCard = ({
   const enrollmentType = determineEnrollmentType({
     subsidyData: { userSubsidyApplicableToCourse },
     userHasSubsidyRequestForCourse,
+    userHasLearnerCreditRequest,
     isUserEnrolled,
     isEnrollable,
     isCourseStarted,

src/components/course/enrollment/tests/utils.test.js

@@ -22,6 +22,7 @@ describe('determineEnrollmentType', () => {
     isCourseStarted: true,
     subsidyData: { userSubsidyApplicableToCourse: null },
     userHasSubsidyRequestForCourse: false,
+    userHasLearnerCreditRequest: false,
   };
 
   test('resolves user-enrolled, course-started to "to courseware page" type', () => {
@@ -94,6 +95,20 @@ describe('determineEnrollmentType', () => {
     expect(determineEnrollmentType(args)).toBe(HIDE_BUTTON);
   });
 
+  test('prioritizes direct subsidy over a requestable one', () => {
+    const args = {
+      ...baseArgs,
+      subsidyData: {
+        ...baseArgs.subsidyData,
+        userSubsidyApplicableToCourse: { subsidyType: LICENSE_SUBSIDY_TYPE },
+      },
+      userCanRequestSubsidyForCourse: true,
+      userHasSubsidyRequestForCourse: false,
+      userHasLearnerCreditRequest: false,
+    };
+    expect(determineEnrollmentType(args)).toBe(TO_DATASHARING_CONSENT);
+  });
+
   test.each([
     { hasSubsidyData: true },
     { hasSubsidyData: false },

src/components/course/enrollment/utils.js

@@ -55,16 +55,20 @@ export function determineEnrollmentType({
   isEnrollable,
   isCourseStarted,
   userHasSubsidyRequestForCourse,
+  userHasLearnerCreditRequest,
   isExecutiveEducation2UCourse,
   userCanRequestSubsidyForCourse,
 }) {
   if (isUserEnrolled) {
     return isCourseStarted ? TO_COURSEWARE_PAGE : VIEW_ON_DASHBOARD;
   }
 
-  // Hide enroll button if learner can request a subsidy for the course, or
-  // already has an pending subsidy request for the course.
-  if (userHasSubsidyRequestForCourse || userCanRequestSubsidyForCourse) {
+  // Hide enroll button if learner can request a subsidy for the course (and has no direct subsidy),
+  // or already has a pending subsidy request for the course.
+  if (
+    (userCanRequestSubsidyForCourse && !userSubsidyApplicableToCourse)
+    || userHasLearnerCreditRequest || userHasSubsidyRequestForCourse
+  ) {
     return HIDE_BUTTON;
   }