Skip to content

feat: increased font size for Dates and Course unit pages#1602

Closed
vladislavkeblysh wants to merge 2 commits intoopenedx:masterfrom
raccoongang:keblysh/feat/font-size-course-unit-dates
Closed

feat: increased font size for Dates and Course unit pages#1602
vladislavkeblysh wants to merge 2 commits intoopenedx:masterfrom
raccoongang:keblysh/feat/font-size-course-unit-dates

Conversation

@vladislavkeblysh
Copy link
Copy Markdown

@vladislavkeblysh vladislavkeblysh commented Feb 24, 2025

Description

Font size increased for selected small text on Course unit and Dates pages.

  1. Increase font size inside Notification tray.
  2. Increase font size for target elements from screenshot. (Dates page)

Testing instructions

Course Unit Page

  1. Open the Course unit page.
  2. Check that font size is increased
  3. Ensure the notification font size is a readable.
  4. Ensure the content is displayed correctly on mobile screens (Notification tray modal window).

Dates Page

  1. Open the Dates page.
  2. Increase font size for target elements from screenshot.
  3. Ensure the content is displayed correctly on mobile screens.

1
2
3

@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Feb 24, 2025

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2025
@vladislavkeblysh vladislavkeblysh self-assigned this Feb 24, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (756fbba) to head (47ef2ab).
⚠️ Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1602      +/-   ##
==========================================
+ Coverage   90.18%   90.33%   +0.15%     
==========================================
  Files         338      338              
  Lines        5726     5734       +8     
  Branches     1382     1346      -36     
==========================================
+ Hits         5164     5180      +16     
+ Misses        543      537       -6     
+ Partials       19       17       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd added the product review PR requires product review before merging label Feb 27, 2025
@itsjeyd
Copy link
Copy Markdown

itsjeyd commented Feb 27, 2025

@vladislavkeblysh Thank you for this contribution!

Same note about product review here.

@itsjeyd
Copy link
Copy Markdown

itsjeyd commented Apr 1, 2025

Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Apr 10, 2025
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/font-size-course-unit-dates branch from 025c06f to 71737b0 Compare April 15, 2025 13:44
@vladislavkeblysh vladislavkeblysh requested review from BilalQamar95, Lunyachek and ihor-romaniuk and removed request for BilalQamar95 April 15, 2025 14:04
@vladislavkeblysh
Copy link
Copy Markdown
Author

@itsjeyd This PR ready to review

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/font-size-course-unit-dates branch from 5c69111 to 47ef2ab Compare April 16, 2025 06:39
@itsjeyd
Copy link
Copy Markdown

itsjeyd commented Apr 24, 2025

@vladislavkeblysh Same question here.

@itsjeyd itsjeyd removed the inactive PR author has been unresponsive for several months label Apr 24, 2025
@PKulkoRaccoonGang
Copy link
Copy Markdown
Contributor

[inform]: Awaiting Product Review

@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 24, 2025
@vladislavkeblysh vladislavkeblysh marked this pull request as draft May 1, 2025 14:06
@PKulkoRaccoonGang
Copy link
Copy Markdown
Contributor

Some context after accessibility review:

The LMS default body text is smaller than recommended for optimal readability. Adjusting the relevant CSS font-size to 1.2 ($font-size-base) rem appears to address the issue.

@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels May 6, 2025
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question]: Do we need this empty file?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question]: Do we need this empty file?

@itsjeyd itsjeyd added the inactive PR author has been unresponsive for several months label Jul 24, 2025
@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@itsjeyd
Copy link
Copy Markdown

itsjeyd commented Aug 25, 2025

Hi @vladislavkeblysh, just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work.

@itsjeyd itsjeyd closed this Aug 25, 2025
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 25, 2025
@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed inactive PR author has been unresponsive for several months labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed inactivity PR was closed because the author abandoned it create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants