feat: increased font size for Dates and Course unit pages#1602
feat: increased font size for Dates and Course unit pages#1602vladislavkeblysh wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 90.18% 90.33% +0.15%
==========================================
Files 338 338
Lines 5726 5734 +8
Branches 1382 1346 -36
==========================================
+ Hits 5164 5180 +16
+ Misses 543 537 -6
+ Partials 19 17 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@vladislavkeblysh Thank you for this contribution! Same note about product review here. |
|
Hey @vladislavkeblysh, just checking in to see if you're still planning to continue working on this PR? |
025c06f to
71737b0
Compare
|
@itsjeyd This PR ready to review |
5c69111 to
47ef2ab
Compare
|
[inform]: Awaiting Product Review |
|
Some context after accessibility review: The LMS default body text is smaller than recommended for optimal readability. Adjusting the relevant CSS font-size to 1.2 ($font-size-base) rem appears to address the issue. |
There was a problem hiding this comment.
[question]: Do we need this empty file?
There was a problem hiding this comment.
[question]: Do we need this empty file?
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
Hi @vladislavkeblysh, just a quick update that I'm closing this PR now because it is stale. You're welcome to reopen this pull request, or open a new one, when you have time to come back to this work. |
Description
Font size increased for selected small text on Course unit and Dates pages.
Testing instructions
Course Unit Page
Dates Page