Skip to content

Commit 3a96817

Browse files
authored
status alert done state (#145)
* chore: update messages * chore: small styling
1 parent b773945 commit 3a96817

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

src/components/ModalContainer.jsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ const ModalContainer = ({ children }) => {
3939
}}
4040
>
4141
<Button
42-
variant="primary"
4342
className="text-white"
4443
onClick={onClose.action.onClick}
4544
>

src/components/StatusAlert/hooks/simpleAlerts.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export const useStaffAlerts = ({ step }) => ([
3131
useCreateAlert({ step })({
3232
message: messages.alerts[stepNames.staff][stepNames.staff],
3333
heading: messages.headings[stepNames.staff][stepNames.staff],
34+
variant: 'warning',
3435
}),
3536
]);
3637

src/components/StatusAlert/index.jsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ const StatusAlert = ({
2525
);
2626

2727
React.useEffect(() => {
28-
document.querySelector('html').scrollTo(0, 0);
28+
document.querySelector('html').scrollTo({
29+
top: 0,
30+
behavior: 'smooth',
31+
});
2932
}, [hasSubmitted, step]);
3033

3134
if (isPageDataLoading) {

src/components/StatusAlert/messages.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ const doneAlerts = defineMessages({
196196
const doneHeadings = defineMessages({
197197
status: {
198198
id: 'frontend-app-ora.StatusAlert.Heading.status',
199-
defaultMessage: 'You have successfully submitted your self assessment',
199+
defaultMessage: 'Great work! All assignment steps are completed.',
200200
description: 'Done status alert heading',
201201
},
202202
});
@@ -210,7 +210,7 @@ const staffAlerts = defineMessages({
210210
const staffHeadings = defineMessages({
211211
staff: {
212212
id: 'ora-mfe.StatusAlert.Heading.xblock.staffAssessment',
213-
defaultMessage: 'Great work! All assignment steps are completed.',
213+
defaultMessage: 'All assignment steps are completed. Your final grade is not ready yet.',
214214
description: 'Status alert message heading for staff assessment step',
215215
},
216216
});

0 commit comments

Comments
 (0)