Skip to content

Commit 961628e

Browse files
authored
chore: add step order on collapse (#140)
1 parent c3e2c40 commit 961628e

File tree

5 files changed

+22
-9
lines changed

5 files changed

+22
-9
lines changed

src/components/ProgressBar/index.jsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,14 +70,20 @@ export const ProgressBar = ({ className }) => {
7070
if (activeStepTitle === stepNames.staff) {
7171
activeStepTitle = stepNames.submission;
7272
}
73+
const stepIndex = stepOrders.indexOf(activeStepTitle) + 1;
74+
const totalSteps = stepOrders.length;
7375

7476
return (
7577
<Navbar className={classNames('px-0', className)} expand={stepOrders.length > 4 ? 'lg' : 'md'}>
76-
<Navbar.Toggle className="w-100 border-0">
78+
<Navbar.Toggle className="w-100 border-primary">
7779
<div className="d-flex justify-content-between m-0 h3">
7880
<span className="d-flex">
7981
<Icon src={ArrowForwardIos} className="mr-2" />
8082
{formatMessage(stepLabels[activeStepTitle])}
83+
{formatMessage(messages.step, {
84+
stepIndex,
85+
totalSteps,
86+
})}
8187
</span>
8288
<Icon src={ArrowDropUpDown} />
8389
</div>

src/components/ProgressBar/index.scss

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,25 +32,27 @@
3232
color: white;
3333
border-radius: 100%;
3434
}
35-
.active {
36-
border-bottom: 2px solid black;
37-
}
3835
}
3936

4037
@mixin navbar-collapse-definition {
4138
width: 100%;
4239
flex-direction: column;
4340
align-items: start;
44-
border-top: 1px solid black;
45-
padding: 0 map-get($spacers, 3);
41+
padding: 0;
4642

4743
.ora-progress-divider {
4844
display: none;
4945
}
5046

5147
.ora-progress-nav {
5248
width: 100%;
53-
margin: 0 0.25rem;
49+
&.is-active {
50+
border: none;
51+
background-color: $light;
52+
}
53+
}
54+
.nav-icon {
55+
margin-left: map-get($spacers, 3);
5456
}
5557
}
5658

src/components/ProgressBar/messages.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,11 @@ const messages = defineMessages({
2626
defaultMessage: 'My grade',
2727
description: 'My Grade step progress indicator',
2828
},
29+
step: {
30+
id: 'frontend-app-ora.ProgressBar.step',
31+
defaultMessage: ' (Step {stepIndex}/{totalSteps})',
32+
description: 'Step progress indicator',
33+
},
2934
});
3035

3136
export default messages;

src/components/StepProgressIndicator/messages.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const messages = defineMessages({
77
id: 'frontend-app-ora.StepProgressIndicator.progress',
88
},
99
gradeNextPeerOptional: {
10-
defaultMessage: 'Grade next peer(optional)',
10+
defaultMessage: 'Grade next peer (optional)',
1111
description: 'When peer response is optional',
1212
id: 'frontend-app-ora.StepProgressIndicator.optional',
1313
},

src/views/XBlockView/Actions/messages.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const messages = defineMessages({
3030
},
3131
optional: {
3232
id: 'ora-mfe.ModalActions.optionalPeerResponse',
33-
defaultMessage: '(optional)',
33+
defaultMessage: ' (optional)',
3434
description: 'When peer response is optional',
3535
},
3636
});

0 commit comments

Comments
 (0)