chore: bug fix for staff step (#142)

* chore: bug fix for staff step

* chore: scroll to the top

* chore: update test

Author: leangseu-edx

src/components/StatusAlert/hooks/useSuccessAlerts.js

@@ -28,7 +28,8 @@ const useSuccessAlerts = ({ step }) => {
       ...alertTypes.success,
     };
     if (activeStepState === stepStates.inProgress) {
-      if (activeStepName !== viewStep) {
+      // startStepAction is null when the user is on the staff and submission steps
+      if (activeStepName !== viewStep && startStepAction !== null) {
         successAlert.actions = [startStepAction.action];
       } else if (viewStep === stepNames.peer) {
         successAlert.actions = [loadNextAction.action];

src/components/StatusAlert/index.jsx

@@ -25,7 +25,7 @@ const StatusAlert = ({
   );
 
   React.useEffect(() => {
-    window.scrollTo(0, 0);
+    document.querySelector('html').scrollTo(0, 0);
   }, [hasSubmitted, step]);
 
   if (isPageDataLoading) {

src/test/smoke.test.jsx

@@ -47,6 +47,15 @@ jest.mock('components/HotjarSurvey', () => 'HotjarSurvey');
 jest.unmock('react');
 jest.unmock('@edx/paragon');
 
+jest.spyOn(document, 'querySelector').mockImplementation((selector) => {
+  if (selector === 'html') {
+    return {
+      scrollTo: jest.fn(),
+    };
+  }
+  return selector;
+});
+
 const post = jest.fn();
 const lmsBaseUrl = 'test-base-url';
 const courseId = 'test-course-id';
@@ -102,8 +111,6 @@ const mockPageData = (url, { body, response }) => {
 
 let el;
 
-global.scrollTo = jest.fn();
-
 describe('Integration smoke tests', () => {
   beforeEach(() => {
     jest.clearAllMocks();