Skip to content

Commit deeba6b

Browse files
authored
chore: remove react callback for this one because hook inconsistency (#182)
* chore: remove react callback for this one because hook inconsistency * chore: lint
1 parent 4125605 commit deeba6b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

src/hooks/actions/useLoadNextAction.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import React from 'react';
21
import { useIntl } from '@edx/frontend-platform/i18n';
32

43
import { usePageDataStatus, useRefreshPageData, useStepInfo } from 'hooks/app';
@@ -28,12 +27,12 @@ export default () => {
2827

2928
return {
3029
action: {
31-
onClick: React.useCallback(() => {
30+
onClick: () => {
3231
if (isMounted.current) {
3332
refreshPageData();
3433
resetAssessment();
3534
}
36-
}, [refreshPageData, resetAssessment, isMounted]),
35+
},
3736
labels: {
3837
default: label(messages.loadNext),
3938
[MutationStatus.idle]: label(messages.loadNext),

src/hooks/actions/useLoadNextAction.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,14 +96,14 @@ describe('useLoadNextAction', () => {
9696
});
9797
it('refreshes page data and assessment on click if mounted', () => {
9898
const { onClick } = useLoadNextAction().action;
99-
onClick.useCallback.cb();
99+
onClick();
100100
expect(refreshPageData).toHaveBeenCalledWith();
101101
expect(resetAssessment).toHaveBeenCalledWith();
102102
});
103103
it('does not refresh data or assessment if not mounted', () => {
104104
when(useIsMounted).calledWith().mockReturnValueOnce({ current: false });
105105
const { onClick } = useLoadNextAction().action;
106-
onClick.useCallback.cb();
106+
onClick();
107107
expect(refreshPageData).not.toHaveBeenCalled();
108108
expect(resetAssessment).not.toHaveBeenCalled();
109109
});

0 commit comments

Comments
 (0)