Skip to content

Commit f5e7ba4

Browse files
author
Ben Warzeski
authored
Merge pull request #28 from openedx/bw/separate_assessments
feat: separate assessments
2 parents ac11f58 + b874c12 commit f5e7ba4

22 files changed

+1074
-935
lines changed

package-lock.json

Lines changed: 815 additions & 762 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/App.jsx

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ import { BrowserRouter as Router, Switch, Route } from 'react-router-dom';
22
import { ErrorPage } from '@edx/frontend-platform/react';
33
import { useIntl } from '@edx/frontend-platform/i18n';
44

5-
import AssessmentView from 'views/AssessmentView';
5+
import PeerAssessmentView from 'views/PeerAssessmentView';
6+
import SelfAssessmentView from 'views/SelfAssessmentView';
7+
import StudentTrainingView from 'views/StudentTrainingView';
68
import SubmissionView from 'views/SubmissionView';
79
import messages from './messages';
810
import routes from './routes';
@@ -13,8 +15,14 @@ const RouterRoot = () => {
1315
return (
1416
<Router>
1517
<Switch>
16-
<Route path={routes.assessment}>
17-
<AssessmentView />
18+
<Route path={routes.peerAssessment}>
19+
<PeerAssessmentView />
20+
</Route>
21+
<Route path={routes.selfAssessment}>
22+
<SelfAssessmentView />
23+
</Route>
24+
<Route path={routes.studentTraining}>
25+
<StudentTrainingView />
1826
</Route>
1927
<Route path={routes.submission}>
2028
<SubmissionView />

src/data/services/lms/api/constants.js

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/data/services/lms/api/hooks.js

Lines changed: 0 additions & 157 deletions
This file was deleted.

src/data/services/lms/hooks/api.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ describe('lms api hooks', () => {
3535
});
3636

3737
const mockUseQueryForORA = (hasData) => {
38+
console.log({ useQuery });
3839
when(useQuery)
3940
.calledWith(expect.objectContaining({ queryKey: [queryKeys.oraConfig] }))
4041
.mockImplementationOnce(mockUseQuery(hasData));
@@ -111,7 +112,7 @@ describe('lms api hooks', () => {
111112
});
112113
describe('assessment', () => {
113114
beforeEach(() => {
114-
mockUseRouteMatch(routes.assessment);
115+
mockUseRouteMatch(routes.peerAssessment);
115116
mockUseQueryForPageData(fakeData.pageData.shapes.peerAssessment, true);
116117
out = testUsePageData();
117118
});

src/data/services/lms/hooks/api.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const useORAConfig = (): types.QueryData<types.ORAConfig> => {
2525

2626
export const usePageData = (): types.QueryData<types.PageData> => {
2727
const route = useRouteMatch();
28-
const isAssessment = route.path === routes.assessment;
28+
const isAssessment = route.path === routes.peerAssessment;
2929
const returnData = isAssessment
3030
? fakeData.pageData.shapes.peerAssessment
3131
: fakeData.pageData.shapes.emptySubmission;

src/routes.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
export default {
2-
assessment: '/assessment/:id',
2+
peerAssessment: '/peer_assessment/:id',
3+
selfAssessment: '/self_assessment/:id',
4+
studentTraining: '/student_training/:id',
35
submission: '/submission/:id',
46
root: '/*',
57
};

0 commit comments

Comments
 (0)