Skip to content

Commit d651b6c

Browse files
authored
fix: clean up unused dependencies and env variables (#471)
* build: cleanup environment variables Setting 'null' to an empty string '' (which is falsy and the right thing here) * fix: clean up unused dependencies - Removing a number of packages from dependencies that simply were not in use. - Removing 'font-awesome' dependency which we didn't actually need in our stylesheet - we don't use it, though we were importing it and setting a variable from it. Not sure why it was ever there. * fix: remove unused dependency We get 'history' through frontend-platform.
1 parent 0fb10ab commit d651b6c

File tree

5 files changed

+59
-192
lines changed

5 files changed

+59
-192
lines changed

.env

Lines changed: 18 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,23 @@
11
NODE_ENV='production'
2-
ACCESS_TOKEN_COOKIE_NAME=null
3-
BASE_URL=null
4-
CREDENTIALS_BASE_URL=null
5-
CSRF_TOKEN_API_PATH=null
6-
ECOMMERCE_BASE_URL=null
7-
LANGUAGE_PREFERENCE_COOKIE_NAME=null
8-
LMS_BASE_URL=null
9-
LOGIN_URL=null
10-
LOGOUT_URL=null
11-
MARKETING_SITE_BASE_URL=null
12-
ORDER_HISTORY_URL=null
13-
REFRESH_ACCESS_TOKEN_ENDPOINT=null
14-
SEGMENT_KEY=null
2+
ACCESS_TOKEN_COOKIE_NAME=''
3+
BASE_URL=''
4+
CREDENTIALS_BASE_URL=''
5+
CSRF_TOKEN_API_PATH=''
6+
ECOMMERCE_BASE_URL=''
7+
LANGUAGE_PREFERENCE_COOKIE_NAME=''
8+
LMS_BASE_URL=''
9+
LOGIN_URL=''
10+
LOGOUT_URL=''
11+
MARKETING_SITE_BASE_URL=''
12+
ORDER_HISTORY_URL=''
13+
REFRESH_ACCESS_TOKEN_ENDPOINT=''
14+
SEGMENT_KEY=''
1515
SITE_NAME=''
16-
USER_INFO_COOKIE_NAME=null
17-
APPLE_APP_STORE_URL=null
18-
CONTACT_URL=null
19-
ENTERPRISE_LEARNER_PORTAL_HOSTNAME=null
20-
ENTERPRISE_MARKETING_FOOTER_UTM_MEDIUM=null
21-
ENTERPRISE_MARKETING_URL=null
22-
ENTERPRISE_MARKETING_UTM_CAMPAIGN=null
23-
ENTERPRISE_MARKETING_UTM_SOURCE=null
24-
FACEBOOK_URL=null
25-
GOOGLE_PLAY_URL=null
26-
LINKED_IN_URL=null
27-
OPEN_SOURCE_URL=null
28-
PRIVACY_POLICY_URL=null
29-
REDDIT_URL=null
30-
SUPPORT_URL=null
31-
TERMS_OF_SERVICE_URL=null
32-
TWITTER_URL=null
33-
YOU_TUBE_URL=null
16+
USER_INFO_COOKIE_NAME=''
17+
CONTACT_URL=''
18+
ENTERPRISE_LEARNER_PORTAL_HOSTNAME=''
19+
SUPPORT_URL=''
20+
TERMS_OF_SERVICE_URL=''
3421
LOGO_URL=''
3522
LOGO_TRADEMARK_URL=''
3623
LOGO_WHITE_URL=''

.env.development

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,13 @@ LOGOUT_URL='http://localhost:18000/logout'
1212
MARKETING_SITE_BASE_URL='http://localhost:18000'
1313
ORDER_HISTORY_URL='localhost:1996/orders'
1414
REFRESH_ACCESS_TOKEN_ENDPOINT='http://localhost:18000/login_refresh'
15-
SEGMENT_KEY=null
15+
SEGMENT_KEY=''
1616
SITE_NAME=localhost
1717
USER_INFO_COOKIE_NAME='edx-user-info'
18-
APPLE_APP_STORE_URL='https://www.apple.com/ios/app-store/'
1918
CONTACT_URL='http://localhost:18000/contact'
2019
ENTERPRISE_LEARNER_PORTAL_HOSTNAME='http://localhost:8080'
21-
ENTERPRISE_MARKETING_FOOTER_UTM_MEDIUM='Footer'
22-
ENTERPRISE_MARKETING_URL='http://example.com'
23-
ENTERPRISE_MARKETING_UTM_CAMPAIGN='my_campaign'
24-
ENTERPRISE_MARKETING_UTM_SOURCE='edX profile'
25-
FACEBOOK_URL='https://www.facebook.com'
26-
GOOGLE_PLAY_URL='https://play.google.com/store'
27-
LINKED_IN_URL='https://www.linkedin.com'
28-
OPEN_SOURCE_URL='http://localhost:18000/openedx'
29-
PRIVACY_POLICY_URL='http://localhost:18000/privacy-policy'
30-
REDDIT_URL='https://www.reddit.com'
3120
SUPPORT_URL='http://localhost:18000/support'
3221
TERMS_OF_SERVICE_URL='http://localhost:18000/terms-of-service'
33-
TWITTER_URL='https://twitter.com'
34-
YOU_TUBE_URL='https://www.youtube.com'
3522
LOGO_URL=https://edx-cdn.org/v3/default/logo.svg
3623
LOGO_TRADEMARK_URL=https://edx-cdn.org/v3/default/logo-trademark.svg
3724
LOGO_WHITE_URL=https://edx-cdn.org/v3/default/logo-white.svg

0 commit comments

Comments
 (0)