Skip to content

feat: addd countries changes for embargo#1166

Merged
sundasnoreen12 merged 6 commits intomasterfrom
sundas/INF-1779
Feb 22, 2025
Merged

feat: addd countries changes for embargo#1166
sundasnoreen12 merged 6 commits intomasterfrom
sundas/INF-1779

Conversation

@sundasnoreen12
Copy link
Contributor

Description

We are introducing a feature that allows platform administrators to restrict users from selecting one or more countries in Profile MFEs.

How Has This Been Tested?

We retrieved the list of restricted countries by calling the following API:

👉 https://courses.edx.org/user_api/v1/account/registration/

At the same time, we obtained the translated country names using the i18n-iso-countries package.

Once both datasets were available, we filtered out the restricted countries from the translated list and displayed the updated country list in the UI.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/2u-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.47%. Comparing base (9593641) to head (9a26dc7).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/profile/data/services.js 0.00% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
- Coverage   66.90%   66.47%   -0.43%     
==========================================
  Files          51       51              
  Lines         855      877      +22     
  Branches      176      180       +4     
==========================================
+ Hits          572      583      +11     
- Misses        272      282      +10     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari
Copy link
Contributor

Please improve test coverage

@sundasnoreen12 sundasnoreen12 merged commit 22dc854 into master Feb 22, 2025
6 of 8 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1779 branch February 22, 2025 10:10
@sundasnoreen12 sundasnoreen12 restored the sundas/INF-1779 branch February 24, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants