Skip to content

Commit 2dd5f43

Browse files
committed
feat: inactive roles
Implement authentication inactive roles while also refactoring the naming scheme to reflect uncertainty (not sure if we're going to want to version these).
1 parent 19e5198 commit 2dd5f43

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

shell/app.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,14 @@ import { App } from '../types';
33
import { Footer } from './footer';
44
import { Header } from './header';
55

6+
const inactive = [
7+
'org.openedx.frontend.role.login',
8+
'org.openedx.frontend.role.register',
9+
'org.openedx.frontend.role.resetPassword',
10+
'org.openedx.frontend.role.confirmPassword',
11+
'org.openedx.frontend.role.welcome'
12+
];
13+
614
const app: App = {
715
appId: 'org.openedx.frontend.app.shell',
816
slots: [
@@ -12,7 +20,7 @@ const app: App = {
1220
op: WidgetOperationTypes.APPEND,
1321
component: Header,
1422
condition: {
15-
inactive: ['org.openedx.frontend.role.authn.main.v1'],
23+
inactive,
1624
}
1725
},
1826
{
@@ -21,7 +29,7 @@ const app: App = {
2129
op: WidgetOperationTypes.APPEND,
2230
component: Footer,
2331
condition: {
24-
inactive: ['org.openedx.frontend.role.authn.main.v1'],
32+
inactive,
2533
}
2634
},
2735
]

shell/dev/devHome/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const app: App = {
99
id: 'org.openedx.frontend.route.dev.home',
1010
Component: HomePage,
1111
handle: {
12-
role: 'org.openedx.frontend.role.dev.home'
12+
role: 'org.openedx.frontend.role.devHome'
1313
}
1414
}],
1515
messages,

shell/header/app.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ const config: App = {
6666
element: (
6767
<ProfileLinkMenuItem
6868
label={messages['header.user.menu.profile']}
69-
role="org.openedx.frontend.role.profile.main.v1"
69+
role="org.openedx.frontend.role.profile"
7070
variant="dropdownItem"
7171
/>
7272
)
@@ -78,7 +78,7 @@ const config: App = {
7878
element: (
7979
<LinkMenuItem
8080
label={messages['header.user.menu.account']}
81-
role="org.openedx.frontend.role.account.main.v1"
81+
role="org.openedx.frontend.role.account"
8282
variant="dropdownItem"
8383
/>
8484
)
@@ -90,7 +90,7 @@ const config: App = {
9090
element: (
9191
<LinkMenuItem
9292
label={messages['header.user.menu.logout']}
93-
role="org.openedx.frontend.role.logout.main.v1"
93+
role="org.openedx.frontend.role.logout"
9494
variant="dropdownItem"
9595
/>
9696
)

shell/site.config.dev.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,15 @@ const siteConfig: SiteConfig = {
1818

1919
externalRoutes: [
2020
{
21-
role: 'org.openedx.frontend.role.profile.main.v1',
21+
role: 'org.openedx.frontend.role.profile',
2222
url: 'http://apps.local.openedx.io:1995/profile/'
2323
},
2424
{
25-
role: 'org.openedx.frontend.role.account.main.v1',
25+
role: 'org.openedx.frontend.role.account',
2626
url: 'http://apps.local.openedx.io:1997/account/'
2727
},
2828
{
29-
role: 'org.openedx.frontend.role.logout.main.v1',
29+
role: 'org.openedx.frontend.role.logout',
3030
url: 'http://local.openedx.io:8000/logout'
3131
},
3232
],

0 commit comments

Comments
 (0)