Skip to content

Commit 7e3966f

Browse files
asadali145asadali145
committed
refactor: more updates
1 parent c4ad876 commit 7e3966f

File tree

6 files changed

+20
-21
lines changed

6 files changed

+20
-21
lines changed

‎.env.development

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,5 @@ CONTACT_URL=
2828
SUPPORT_CENTER_URL=
2929
SUPPORT_CENTER_TEXT=
3030
TRADEMARK_TEXT=
31-
SITE_URL=
3231
LOGO_ALT_TEXT=
3332
SHOW_LOGO=

‎README.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ Reporting Security Issues
184184
=========================
185185

186186
Please do not report security issues in public. Please email [email protected].
187+
187188
.. |Build Status| image:: https://api.travis-ci.com/edx/frontend-component-footer.svg?branch=master
188189
:target: https://travis-ci.com/edx/frontend-component-footer
189190
.. |Codecov| image:: https://img.shields.io/codecov/c/github/edx/frontend-component-footer

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@edx/frontend-component-footer-mitol",
2+
"name": "@edx/frontend-component-footer",
33
"version": "1.0.0-semantically-released",
44
"description": "Footer component for use when building Open edX frontend applications",
55
"main": "dist/index.js",

‎src/components/Footer.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class SiteFooter extends React.Component {
7979
{this.renderLinkIfExists(process.env.TERMS_OF_SERVICE_URL, 'Terms of Service')}
8080
{this.renderLinkIfExists(process.env.PRIVACY_POLICY_URL, 'Privacy Policy')}
8181
{this.renderLinkIfExists(process.env.HONOR_CODE_URL, 'Honor Code')}
82-
{this.renderLinkIfExists(process.env.Contact, 'Contact')}
82+
{this.renderLinkIfExists(process.env.CONTACT_URL, 'Contact Us')}
8383
{this.renderLinkIfExists(process.env.ACCESSIBILITY_URL, 'Accessibility')}
8484
{this.renderLinkIfExists(process.env.SUPPORT_CENTER_URL, process.env.SUPPORT_CENTER_TEXT || 'FAQ & Help')}
8585
</ul>

‎src/components/__snapshots__/Footer.test.jsx.snap

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ exports[`<Footer /> renders correctly renders with a language selector 1`] = `
4444
</li>
4545
<li>
4646
<a
47-
href="http://localhost:18000/tos_and_honor"
47+
href="http://localhost:18000/terms-of-service"
4848
>
4949
Terms of Service
5050
</a>
@@ -58,21 +58,21 @@ exports[`<Footer /> renders correctly renders with a language selector 1`] = `
5858
</li>
5959
<li>
6060
<a
61-
href="http://localhost:18000/tos_and_honor"
61+
href="http://localhost:18000/honor"
6262
>
6363
Honor Code
6464
</a>
6565
</li>
6666
<li>
6767
<a
68-
href="https://accessibility.mit.edu/"
68+
href="https://www.edx.org/accessibility"
6969
>
7070
Accessibility
7171
</a>
7272
</li>
7373
<li>
7474
<a
75-
href="http://localhost:18000/about"
75+
href="http://localhost:18000/contact"
7676
>
7777
SUPPORT CENTER
7878
</a>
@@ -170,7 +170,7 @@ exports[`<Footer /> renders correctly renders without a language selector 1`] =
170170
</li>
171171
<li>
172172
<a
173-
href="http://localhost:18000/tos_and_honor"
173+
href="http://localhost:18000/terms-of-service"
174174
>
175175
Terms of Service
176176
</a>
@@ -184,21 +184,21 @@ exports[`<Footer /> renders correctly renders without a language selector 1`] =
184184
</li>
185185
<li>
186186
<a
187-
href="http://localhost:18000/tos_and_honor"
187+
href="http://localhost:18000/honor"
188188
>
189189
Honor Code
190190
</a>
191191
</li>
192192
<li>
193193
<a
194-
href="https://accessibility.mit.edu/"
194+
href="https://www.edx.org/accessibility"
195195
>
196196
Accessibility
197197
</a>
198198
</li>
199199
<li>
200200
<a
201-
href="http://localhost:18000/about"
201+
href="http://localhost:18000/contact"
202202
>
203203
SUPPORT CENTER
204204
</a>
@@ -257,7 +257,7 @@ exports[`<Footer /> renders correctly renders without a language selector in es
257257
</li>
258258
<li>
259259
<a
260-
href="http://localhost:18000/tos_and_honor"
260+
href="http://localhost:18000/terms-of-service"
261261
>
262262
Terms of Service
263263
</a>
@@ -271,21 +271,21 @@ exports[`<Footer /> renders correctly renders without a language selector in es
271271
</li>
272272
<li>
273273
<a
274-
href="http://localhost:18000/tos_and_honor"
274+
href="http://localhost:18000/honor"
275275
>
276276
Honor Code
277277
</a>
278278
</li>
279279
<li>
280280
<a
281-
href="https://accessibility.mit.edu/"
281+
href="https://www.edx.org/accessibility"
282282
>
283283
Accessibility
284284
</a>
285285
</li>
286286
<li>
287287
<a
288-
href="http://localhost:18000/about"
288+
href="http://localhost:18000/contact"
289289
>
290290
SUPPORT CENTER
291291
</a>

‎src/setupTest.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,13 @@ process.env.LOGO_WHITE_URL = 'https://edx-cdn.org/v3/default/logo-white.svg';
2121
process.env.FAVICON_URL = 'https://edx-cdn.org/v3/default/favicon.ico';
2222
process.env.ABOUT_US_URL = 'http://localhost:18000/about';
2323
process.env.PRIVACY_POLICY_URL = 'http://localhost:18000/privacy';
24-
process.env.HONOR_CODE_URL = 'http://localhost:18000/tos_and_honor';
25-
process.env.TERMS_OF_SERVICE_URL = 'http://localhost:18000/tos_and_honor';
26-
process.env.CONTACT_URL = 'http://localhost:18000/about';
27-
process.env.SUPPORT_CENTER_URL = 'http://localhost:18000/about';
24+
process.env.HONOR_CODE_URL = 'http://localhost:18000/honor';
25+
process.env.TERMS_OF_SERVICE_URL = 'http://localhost:18000/terms-of-service';
26+
process.env.CONTACT_URL = 'http://localhost:18000/contact';
27+
process.env.SUPPORT_CENTER_URL = 'http://localhost:18000/contact';
2828
process.env.SUPPORT_CENTER_TEXT = 'SUPPORT CENTER';
2929
process.env.TRADEMARK_TEXT = 'Trade Mark text';
30-
process.env.SITE_URL = 'http://localhost:18000/';
3130
process.env.LOGO_ALT_TEXT = 'alt text';
3231
process.env.SHOW_LOGO = true;
3332
process.env.SUPPORT_EMAIL = '[email protected]';
34-
process.env.ACCESSIBILITY_URL = 'https://accessibility.mit.edu/';
33+
process.env.ACCESSIBILITY_URL = 'https://www.edx.org/accessibility';

0 commit comments

Comments
 (0)