Skip to content

Commit 8109ba3

Browse files
committed
chore: remove husky 🪓🐶
We remove husky, which is triggering pre-push git hooks, including running "npm lint". This is causing failures when building Docker images, because "npm clean-install --omit=dev" automatically triggers "npm prepare", which attemps to run "husky". But husky is not listed in the build dependencies, only in devDependencies. As a consequence, package installation is failing with the following error: 14.13 > @edx/[email protected] prepare 14.13 > husky install 14.13 14.15 sh: 1: husky: not found Similar to: openedx/frontend-app-learning#1622
1 parent ebb8707 commit 8109ba3

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

package-lock.json

Lines changed: 0 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919
"files": [
2020
"/dist"
2121
],
22-
"husky": {
23-
"hooks": {
24-
"pre-commit": "npm run lint"
25-
}
26-
},
2722
"repository": {
2823
"type": "git",
2924
"url": "git+https://github.com/openedx/frontend-component-footer.git"
@@ -46,7 +41,6 @@
4641
"@testing-library/react": "^16.2.0",
4742
"@testing-library/dom": "^10.4.0",
4843
"@testing-library/user-event": "^14.6.1",
49-
"husky": "8.0.3",
5044
"prop-types": "15.8.1",
5145
"react": "^18.3.1",
5246
"react-dom": "^18.3.1",

0 commit comments

Comments
 (0)