Skip to content

Commit 7b8f012

Browse files
committed
build: Upgrade to Node 24
1 parent 20112b4 commit 7b8f012

File tree

4 files changed

+1218
-1134
lines changed

4 files changed

+1218
-1134
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ jobs:
1212
strategy:
1313
matrix:
1414
node: [20, 24]
15-
continue-on-error: ${{ matrix.node == 24 }}
1615
steps:
1716
- name: Checkout
1817
uses: actions/checkout@v4
@@ -21,7 +20,7 @@ jobs:
2120
- name: Setup Nodejs
2221
uses: actions/setup-node@v4
2322
with:
24-
node-version: ${{ matrix.node }}
23+
node-version-file: '.nvmrc'
2524
- name: Install dependencies
2625
run: npm ci
2726
- name: Validate package-lock.json changes

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24

README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ Cloning and Startup
7171
7272
``git clone https://github.com/openedx/frontend-component-header.git``
7373
74-
2. Use node v18.x.
74+
2. Use node v24.x.
7575
76-
The current version of the micro-frontend build scripts support node 18.
76+
The current version of the micro-frontend build scripts support node 24.
7777
Using other major versions of node *may* work, but this is unsupported. For
7878
convenience, this repository includes an .nvmrc file to help in setting the
7979
correct node version via `nvm <https://github.com/nvm-sh/nvm>`_.

0 commit comments

Comments
 (0)