Skip to content

Commit a346dcc

Browse files
feat: add frontend-plugin-framework slots (#545)
Add the following `frontend-plugin-framework` slots: * `logo_slot` * `desktop_main_menu_slot` * `desktop_secondary_menu_slot` * `mobile_main_menu_slot` * `course_info_slot` * `learning_help_slot` * `desktop_logged_out_items_slot` * `mobile_logged_out_items_slot` * `mobile_user_menu_slot` * `desktop_user_menu_slot` * `learning_user_menu_slot` * `learning_logged_out_items_slot` * `desktop_header_slot`
1 parent c64a201 commit a346dcc

File tree

79 files changed

+2328
-401
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+2328
-401
lines changed

src/DesktopHeader.jsx

Lines changed: 0 additions & 222 deletions
This file was deleted.

src/Header.jsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import {
1111
} from '@edx/frontend-platform';
1212

1313
import PropTypes from 'prop-types';
14-
import DesktopHeader from './DesktopHeader';
15-
import MobileHeader from './MobileHeader';
14+
import DesktopHeaderSlot from './plugin-slots/DesktopHeaderSlot';
15+
import MobileHeaderSlot from './plugin-slots/MobileHeaderSlot';
1616

1717
import messages from './Header.messages';
1818

@@ -123,10 +123,10 @@ const Header = ({
123123
return (
124124
<>
125125
<Responsive maxWidth={769}>
126-
<MobileHeader {...props} />
126+
<MobileHeaderSlot props={props} />
127127
</Responsive>
128128
<Responsive minWidth={769}>
129-
<DesktopHeader {...props} />
129+
<DesktopHeaderSlot props={props} />
130130
</Responsive>
131131
</>
132132
);

src/Logo.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ const Logo = ({
1212
</a>
1313
);
1414

15-
Logo.propTypes = {
15+
export const logoDataShape = {
1616
href: PropTypes.string.isRequired,
1717
src: PropTypes.string.isRequired,
1818
alt: PropTypes.string.isRequired,
1919
};
2020

21+
Logo.propTypes = logoDataShape;
22+
2123
export default Logo;

0 commit comments

Comments
 (0)