feat: detekt fixes

Author: PavloNetrebchuk

course/src/main/java/org/openedx/course/presentation/container/CourseContainerFragment.kt

@@ -307,7 +307,9 @@ fun CourseDashboard(
             bottomBar = {
                 val currentPage = CourseContainerTab.entries[pagerState.currentPage]
                 Box {
-                    if (currentPage == CourseContainerTab.CONTENT && selectedContentTab == CourseContentTab.ASSIGNMENTS) {
+                    if (currentPage == CourseContainerTab.CONTENT &&
+                        selectedContentTab == CourseContentTab.ASSIGNMENTS
+                    ) {
                         AssignmentsBottomBar(scope = scope, pagerState = pagerState)
                     } else if (currentPage == CourseContainerTab.HOME) {
                         HomeNavigationRow(homePagerState = homePagerState)

course/src/main/java/org/openedx/course/presentation/home/AssignmentsHomePagerCardContent.kt

@@ -38,6 +38,14 @@ import org.openedx.course.presentation.contenttab.CourseContentAssignmentEmptySt
 import java.util.Date
 import org.openedx.core.R as coreR
 
+private const val MILLISECONDS_PER_SECOND = 1000
+private const val SECONDS_PER_MINUTE = 60
+private const val MINUTES_PER_HOUR = 60
+private const val HOURS_PER_DAY = 24
+
+private const val MILLISECONDS_PER_DAY =
+    MILLISECONDS_PER_SECOND * SECONDS_PER_MINUTE * MINUTES_PER_HOUR * HOURS_PER_DAY
+
 @Composable
 fun AssignmentsHomePagerCardContent(
     uiState: CourseHomeUIState.CourseData,
@@ -153,7 +161,7 @@ private fun AssignmentCard(
     // Due date status text
     val dueDateStatusText = assignment.due?.let { due ->
         val formattedDate = TimeUtils.formatToDayMonth(due)
-        val daysDifference = ((due.time - Date().time) / (1000 * 60 * 60 * 24)).toInt()
+        val daysDifference = ((due.time - Date().time) / MILLISECONDS_PER_DAY).toInt()
         when {
             daysDifference < 0 -> {
                 // Past due
@@ -237,7 +245,6 @@ private fun AssignmentCard(
                         Spacer(modifier = Modifier.height(4.dp))
                     }
 
-
                     // Assignment and section name
                     Text(
                         text = assignment.assignmentProgress?.assignmentType ?: "",

course/src/main/java/org/openedx/course/presentation/home/CourseHomePagerTab.kt

@@ -5,4 +5,4 @@ enum class CourseHomePagerTab {
     VIDEOS,
     ASSIGNMENT,
     GRADES
-}
+}

course/src/main/java/org/openedx/course/presentation/home/CourseHomeScreen.kt

@@ -343,6 +343,8 @@ private fun CourseHomeUI(
                     CourseHomeUIState.Loading -> {
                         CircularProgress()
                     }
+
+                    CourseHomeUIState.Waiting -> {}
                 }
             }
         }

course/src/main/java/org/openedx/course/presentation/home/CourseHomeUIState.kt

@@ -27,4 +27,5 @@ sealed class CourseHomeUIState {
 
     data object Error : CourseHomeUIState()
     data object Loading : CourseHomeUIState()
+    data object Waiting : CourseHomeUIState()
 }

course/src/main/java/org/openedx/course/presentation/home/CourseHomeViewModel.kt

@@ -76,7 +76,7 @@ class CourseHomeViewModel(
 ) {
     val isCourseDropdownNavigationEnabled get() = config.getCourseUIConfig().isCourseDropdownNavigationEnabled
 
-    private val _uiState = MutableStateFlow<CourseHomeUIState>(CourseHomeUIState.Loading)
+    private val _uiState = MutableStateFlow<CourseHomeUIState>(CourseHomeUIState.Waiting)
     val uiState: StateFlow<CourseHomeUIState>
         get() = _uiState.asStateFlow()
 
@@ -337,11 +337,15 @@ class CourseHomeViewModel(
      * where the first Block is the chapter and the second Block is the first incomplete subsection
      */
     private fun findFirstChapterWithIncompleteDescendants(blocks: List<Block>): Pair<Block, Block>? {
-        val incompleteChapterBlock =
-            blocks.getChapterBlocks().find { !it.isCompleted() } ?: return null
-        val incompleteSubsection =
-            findFirstIncompleteSubsection(incompleteChapterBlock, blocks) ?: return null
-        return Pair(incompleteChapterBlock, incompleteSubsection)
+        val incompleteChapterBlock = blocks.getChapterBlocks().find { !it.isCompleted() }
+        val incompleteSubsection = incompleteChapterBlock?.let {
+            findFirstIncompleteSubsection(it, blocks)
+        }
+        return if (incompleteChapterBlock != null && incompleteSubsection != null) {
+            Pair(incompleteChapterBlock, incompleteSubsection)
+        } else {
+            null
+        }
     }
 
     private fun findFirstIncompleteSubsection(chapter: Block, blocks: List<Block>): Block? {
@@ -534,6 +538,9 @@ class CourseHomeViewModel(
 
     fun getCourseProgress() {
         viewModelScope.launch {
+            if (_uiState.value !is CourseHomeUIState.CourseData) {
+                _uiState.value = CourseHomeUIState.Loading
+            }
             interactor.getCourseProgress(courseId, false)
                 .catch { e ->
                     if (_uiState.value !is CourseHomeUIState.CourseData) {

course/src/main/java/org/openedx/course/presentation/home/GradesHomePagerCardContent.kt

@@ -200,4 +200,3 @@ private fun GradeCardsGrid(
         }
     }
 }
-

course/src/main/java/org/openedx/course/presentation/home/VideosHomePagerCardContent.kt

@@ -38,7 +38,6 @@ fun VideosHomePagerCardContent(
     onViewAllVideosClick: () -> Unit
 ) {
     val allVideos = uiState.courseVideos.values.flatten()
-    
     if (allVideos.isEmpty()) {
         CourseContentVideoEmptyState(
             onReturnToCourseClick = {},

course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt

@@ -1755,7 +1755,3 @@ private val mockChapterBlock = Block(
     due = Date(),
     offlineDownload = null
 )
-
-
-
-