Skip to content

Commit 2bd9aa1

Browse files
fix: detekt fix and changes according PR review
1 parent a408106 commit 2bd9aa1

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

core/src/main/java/org/openedx/core/utils/TimeUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ object TimeUtils {
9797
}
9898
}
9999

100-
fun formatToDayMonth(date: Date): String {
100+
fun formatToMonthDay(date: Date): String {
101101
val sdf = SimpleDateFormat("MMM dd", Locale.getDefault())
102102
return sdf.format(date)
103103
}

course/src/main/java/org/openedx/course/presentation/home/AssignmentsHomePagerCardContent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ private fun AssignmentCard(
163163

164164
// Due date status text
165165
val dueDateStatusText = assignment.due?.let { due ->
166-
val formattedDate = TimeUtils.formatToDayMonth(due)
166+
val formattedDate = TimeUtils.formatToMonthDay(due)
167167
val daysDifference = ((due.time - Date().time) / MILLISECONDS_PER_DAY).toInt()
168168
when {
169169
daysDifference < 0 -> {

course/src/test/java/org/openedx/course/presentation/home/CourseHomeViewModelTest.kt

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,13 @@ import org.openedx.foundation.system.ResourceManager
4646
import org.openedx.foundation.utils.FileUtil
4747
import java.net.UnknownHostException
4848

49+
@Suppress("LargeClass")
4950
@OptIn(ExperimentalCoroutinesApi::class)
5051
class CourseHomeViewModelTest {
5152

5253
@get:Rule
5354
val testInstantTaskExecutorRule: TestRule = InstantTaskExecutorRule()
54-
5555
private val dispatcher = StandardTestDispatcher()
56-
5756
private val courseId = "test-course-id"
5857
private val courseTitle = "Test Course"
5958
private val context = mockk<Context>()
@@ -92,8 +91,12 @@ class CourseHomeViewModelTest {
9291

9392
every { resourceManager.getString(R.string.core_error_no_connection) } returns noInternet
9493
every { resourceManager.getString(R.string.core_error_unknown_error) } returns somethingWrong
95-
every { resourceManager.getString(org.openedx.course.R.string.course_can_download_only_with_wifi) } returns cantDownload
96-
every { resourceManager.getString(R.string.core_dates_shift_dates_unsuccessful_msg) } returns "Failed to shift dates"
94+
every {
95+
resourceManager.getString(org.openedx.course.R.string.course_can_download_only_with_wifi)
96+
} returns cantDownload
97+
every {
98+
resourceManager.getString(R.string.core_dates_shift_dates_unsuccessful_msg)
99+
} returns "Failed to shift dates"
97100

98101
every { config.getCourseUIConfig().isCourseDropdownNavigationEnabled } returns true
99102
every { config.getCourseUIConfig().isCourseDownloadQueueEnabled } returns true
@@ -234,14 +237,15 @@ class CourseHomeViewModelTest {
234237
assertTrue(viewModel.uiState.value !is CourseHomeUIState.CourseData)
235238
}
236239

240+
@Suppress("TooGenericExceptionThrown")
237241
@Test
238242
fun `getCourseData unknown error`() = runTest {
239243
coEvery {
240244
interactor.getCourseStructureFlow(
241245
courseId,
242246
false
243247
)
244-
} returns flow { throw Exception("Unknown error") }
248+
} returns flow { throw Exception() }
245249
coEvery { interactor.getCourseStatusFlow(courseId) } returns flow {
246250
emit(
247251
courseComponentStatus
@@ -748,7 +752,6 @@ class CourseHomeViewModelTest {
748752
)
749753

750754
advanceUntilIdle()
751-
752755
}
753756

754757
@Test

0 commit comments

Comments
 (0)