refactor: minor rule changes

Author: PavloNetrebchuk

.github/workflows/detekt.yml

@@ -0,0 +1,33 @@
+name: Detekt
+
+on:
+  workflow_dispatch:
+  pull_request: { }
+
+env:
+  GRADLE_OPTS: -Dorg.gradle.daemon=false
+  CI_GRADLE_ARG_PROPERTIES: --stacktrace
+
+jobs:
+  linting:
+    name: Run Detekt
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v4
+
+      - name: Setup Java
+        uses: actions/setup-java@v4
+        with:
+          distribution: 'temurin' # See 'Supported distributions' for available options
+          java-version: '17'
+
+      - name: Run Detekt
+        run: ./gradlew detektAll
+
+      - name: Upload report
+        uses: github/codeql-action/upload-sarif@v3
+        if: success() || failure()
+        with:
+          sarif_file: build/reports/detekt/detekt.sarif

app/src/main/java/org/openedx/app/di/ScreenModule.kt

@@ -184,7 +184,7 @@ val screenModule = module {
             profileRouter = get(),
         )
     }
-    viewModel { (account: Account) -> EditProfileViewModel(get(), get(), get(), get(), account) }
+    viewModel { (account: Account) -> EditProfileViewModel(get(), get(), get(), get(), get(), account) }
     viewModel { VideoSettingsViewModel(get(), get(), get(), get()) }
     viewModel { (qualityType: String) -> VideoQualityViewModel(qualityType, get(), get(), get()) }
     viewModel { DeleteProfileViewModel(get(), get(), get(), get(), get()) }

config/detekt.yml

@@ -1,5 +1,5 @@
 build:
-  maxIssues: 100
+  maxIssues: 0
   weights:
     complexity: 2
     LongParameterList: 1
@@ -43,19 +43,13 @@ style:
     active: true
     ignoreAnnotated:
       - 'Preview'
-  ForbiddenComment:
-    active: false
-  SerialVersionUIDInSerializableClass:
-    active: false
 
 complexity:
   active: true
   LongMethod:
     active: true
     ignoreAnnotated: [ 'Composable' ]
     ignoreFunction: [ 'onCreateView' ]
-  LargeClass:
-    active: false
   LongParameterList:
     active: true
     functionThreshold: 15
@@ -64,8 +58,8 @@ complexity:
     ignoreAnnotated: [ 'Composable' ]
   TooManyFunctions:
     active: true
-    thresholdInClasses: 30
-    thresholdInInterfaces: 30
+    thresholdInClasses: 21
+    thresholdInInterfaces: 20
     ignoreAnnotatedFunctions: [ 'Composable' ]
     ignoreOverridden: true
     ignorePrivate: true

core/src/main/java/org/openedx/core/config/Config.kt

@@ -8,6 +8,7 @@ import com.google.gson.JsonParser
 import org.openedx.core.domain.model.AgreementUrls
 import java.io.InputStreamReader
 
+@Suppress("TooManyFunctions")
 class Config(context: Context) {
 
     private var configProperties: JsonObject = try {

core/src/main/java/org/openedx/core/domain/model/AppConfig.kt

@@ -1,14 +1,18 @@
 package org.openedx.core.domain.model
 
-import java.io.Serializable
+import com.google.gson.annotations.SerializedName
 
 data class AppConfig(
     val courseDatesCalendarSync: CourseDatesCalendarSync = CourseDatesCalendarSync(),
-) : Serializable
+)
 
 data class CourseDatesCalendarSync(
+    @SerializedName("is_enabled")
     val isEnabled: Boolean = false,
+    @SerializedName("is_self_paced_enabled")
     val isSelfPacedEnabled: Boolean = false,
+    @SerializedName("is_instructor_paced_enabled")
     val isInstructorPacedEnabled: Boolean = false,
+    @SerializedName("is_deep_link_enabled")
     val isDeepLinkEnabled: Boolean = false,
-) : Serializable
+)

discussion/src/test/java/org/openedx/discussion/presentation/comments/DiscussionCommentsViewModelTest.kt

@@ -40,6 +40,7 @@ import org.openedx.foundation.presentation.UIMessage
 import org.openedx.foundation.system.ResourceManager
 import java.net.UnknownHostException
 
+@Suppress("LargeClass")
 @OptIn(ExperimentalCoroutinesApi::class)
 class DiscussionCommentsViewModelTest {
 

profile/src/main/java/org/openedx/profile/presentation/edit/EditProfileFragment.kt

@@ -278,10 +278,9 @@ class EditProfileFragment : Fragment() {
         fos.write(bitmapData)
         fos.flush()
         fos.close()
-        // TODO: get applicationId instead of packageName
         return FileProvider.getUriForFile(
             requireContext(),
-            requireContext().packageName + ".fileprovider",
+            viewModel.config.getAppId() + ".fileprovider",
             newFile
         )!!
     }

profile/src/main/java/org/openedx/profile/presentation/edit/EditProfileViewModel.kt

@@ -6,6 +6,7 @@ import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.viewModelScope
 import kotlinx.coroutines.launch
 import org.openedx.core.R
+import org.openedx.core.config.Config
 import org.openedx.foundation.extension.isInternetError
 import org.openedx.foundation.presentation.BaseViewModel
 import org.openedx.foundation.presentation.UIMessage
@@ -24,6 +25,7 @@ class EditProfileViewModel(
     private val resourceManager: ResourceManager,
     private val notifier: ProfileNotifier,
     private val analytics: ProfileAnalytics,
+    val config: Config,
     account: Account,
 ) : BaseViewModel() {