fix: detekt fix and changes according PR review

Author: PavloNetrebchuk

app/src/main/java/org/openedx/app/AppActivity.kt

@@ -2,7 +2,9 @@ package org.openedx.app
 
 import android.content.Intent
 import android.content.res.Configuration
+import android.graphics.Color
 import android.net.Uri
+import android.os.Build
 import android.os.Bundle
 import android.view.View
 import android.view.WindowManager
@@ -158,8 +160,12 @@ class AppActivity : AppCompatActivity(), InsetHolder, WindowSizeHolder {
             WindowCompat.setDecorFitsSystemWindows(this, false)
             val insetsController = WindowInsetsControllerCompat(this, binding.root)
             insetsController.isAppearanceLightStatusBars = !isUsingNightModeResources()
-            insetsController.systemBarsBehavior =
-                WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM) {
+                insetsController.systemBarsBehavior =
+                    WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
+            } else {
+                window.statusBarColor = Color.TRANSPARENT
+            }
         }
     }
 

core/src/main/java/org/openedx/core/ui/theme/AppColors.kt

@@ -80,6 +80,7 @@ data class AppColors(
     val progressBarColor: Color,
     val progressBarBackgroundColor: Color,
     val gradeProgressBarBorder: Color,
+    val gradeProgressBarBackground: Color,
 ) {
     val primary: Color get() = material.primary
     val primaryVariant: Color get() = material.primaryVariant

core/src/main/java/org/openedx/core/ui/theme/Theme.kt

@@ -97,7 +97,8 @@ private val DarkColorPalette = AppColors(
 
     progressBarColor = dark_progress_bar_color,
     progressBarBackgroundColor = dark_progress_bar_background_color,
-    gradeProgressBarBorder = dark_grade_progress_bar_color
+    gradeProgressBarBorder = dark_grade_progress_bar_color,
+    gradeProgressBarBackground = dark_grade_progress_bar_background,
 )
 
 private val LightColorPalette = AppColors(
@@ -187,7 +188,8 @@ private val LightColorPalette = AppColors(
 
     progressBarColor = light_progress_bar_color,
     progressBarBackgroundColor = light_progress_bar_background_color,
-    gradeProgressBarBorder = light_grade_progress_bar_color
+    gradeProgressBarBorder = light_grade_progress_bar_color,
+    gradeProgressBarBackground = light_grade_progress_bar_background
 )
 
 val MaterialTheme.appColors: AppColors

core/src/main/java/org/openedx/core/utils/TimeUtils.kt

@@ -97,7 +97,7 @@ object TimeUtils {
         }
     }
 
-    fun formatToDayMonth(date: Date): String {
+    fun formatToMonthDay(date: Date): String {
         val sdf = SimpleDateFormat("MMM dd", Locale.getDefault())
         return sdf.format(date)
     }

core/src/openedx/org/openedx/core/ui/theme/Colors.kt

@@ -75,6 +75,7 @@ val light_settings_title_content = Color.White
 val light_progress_bar_color = light_success_green
 val light_progress_bar_background_color = Color(0xFFCCD4E0)
 val light_grade_progress_bar_color = Color.Black
+val light_grade_progress_bar_background = light_background
 
 val dark_primary = Color(0xFF3F68F8)
 val dark_primary_variant = Color(0xFF3700B3)
@@ -149,3 +150,4 @@ val dark_settings_title_content = Color.White
 val dark_progress_bar_color = dark_success_green
 val dark_progress_bar_background_color = Color(0xFF8E9BAE)
 val dark_grade_progress_bar_color = Color.Transparent
+val dark_grade_progress_bar_background = Color(0xFF8E9BAE)

course/src/main/java/org/openedx/course/presentation/home/AssignmentsHomePagerCardContent.kt

@@ -163,7 +163,7 @@ private fun AssignmentCard(
 
     // Due date status text
     val dueDateStatusText = assignment.due?.let { due ->
-        val formattedDate = TimeUtils.formatToDayMonth(due)
+        val formattedDate = TimeUtils.formatToMonthDay(due)
         val daysDifference = ((due.time - Date().time) / MILLISECONDS_PER_DAY).toInt()
         when {
             daysDifference < 0 -> {

course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt

@@ -519,6 +519,7 @@ fun GradeProgressBar(
             Box(
                 modifier = Modifier
                     .weight(notCompletedWeightedGradePercent)
+                    .background(MaterialTheme.appColors.gradeProgressBarBackground)
                     .fillMaxHeight()
             )
         }

course/src/test/java/org/openedx/course/presentation/home/CourseHomeViewModelTest.kt

@@ -46,14 +46,13 @@ import org.openedx.foundation.system.ResourceManager
 import org.openedx.foundation.utils.FileUtil
 import java.net.UnknownHostException
 
+@Suppress("LargeClass")
 @OptIn(ExperimentalCoroutinesApi::class)
 class CourseHomeViewModelTest {
 
     @get:Rule
     val testInstantTaskExecutorRule: TestRule = InstantTaskExecutorRule()
-
     private val dispatcher = StandardTestDispatcher()
-
     private val courseId = "test-course-id"
     private val courseTitle = "Test Course"
     private val context = mockk<Context>()
@@ -92,8 +91,12 @@ class CourseHomeViewModelTest {
 
         every { resourceManager.getString(R.string.core_error_no_connection) } returns noInternet
         every { resourceManager.getString(R.string.core_error_unknown_error) } returns somethingWrong
-        every { resourceManager.getString(org.openedx.course.R.string.course_can_download_only_with_wifi) } returns cantDownload
-        every { resourceManager.getString(R.string.core_dates_shift_dates_unsuccessful_msg) } returns "Failed to shift dates"
+        every {
+            resourceManager.getString(org.openedx.course.R.string.course_can_download_only_with_wifi)
+        } returns cantDownload
+        every {
+            resourceManager.getString(R.string.core_dates_shift_dates_unsuccessful_msg)
+        } returns "Failed to shift dates"
 
         every { config.getCourseUIConfig().isCourseDropdownNavigationEnabled } returns true
         every { config.getCourseUIConfig().isCourseDownloadQueueEnabled } returns true
@@ -234,14 +237,15 @@ class CourseHomeViewModelTest {
         assertTrue(viewModel.uiState.value !is CourseHomeUIState.CourseData)
     }
 
+    @Suppress("TooGenericExceptionThrown")
     @Test
     fun `getCourseData unknown error`() = runTest {
         coEvery {
             interactor.getCourseStructureFlow(
                 courseId,
                 false
             )
-        } returns flow { throw Exception("Unknown error") }
+        } returns flow { throw Exception() }
         coEvery { interactor.getCourseStatusFlow(courseId) } returns flow {
             emit(
                 courseComponentStatus
@@ -748,7 +752,6 @@ class CourseHomeViewModelTest {
         )
 
         advanceUntilIdle()
-
     }
 
     @Test