fix: crash current must not be NaN during bulk download (#63) (#412)

dixidroid · farhan-arshad-dev · web-flow · commit 46c32a2cb457 · 2024-12-11T12:03:01.000+02:00
- Add validation to ensure that the progress value is not NaN.

fixes: LEARNER-10248

Co-authored-by: Farhan Arshad &lt;43750646+farhan-arshad-dev@users.noreply.github.com&gt;
diff --git a/course/src/main/java/org/openedx/course/presentation/ui/CourseVideosUI.kt b/course/src/main/java/org/openedx/course/presentation/ui/CourseVideosUI.kt
@@ -543,7 +543,12 @@ private fun AllVideosDownloadItem(
         )
     }
     if (isDownloadingAllVideos) {
-        val progress = 1 - downloadModelsSize.remainingSize.toFloat() / downloadModelsSize.allSize
+        val progress =
+            if (downloadModelsSize.allSize == 0L) {
+                0f
+            } else {
+                1 - downloadModelsSize.remainingSize.toFloat() / downloadModelsSize.allSize
+            }
 
         val animatedProgress by animateFloatAsState(
             targetValue = progress,

Original file line number	Diff line number	Diff line change
`@@ -543,7 +543,12 @@ private fun AllVideosDownloadItem(`
`543`	`543`	`)`
`544`	`544`	`}`
`545`	`545`	`if (isDownloadingAllVideos) {`
`546`		`- val progress = 1 - downloadModelsSize.remainingSize.toFloat() / downloadModelsSize.allSize`
	`546`	`+ val progress =`
	`547`	`+ if (downloadModelsSize.allSize == 0L) {`
	`548`	`+ 0f`
	`549`	`+ } else {`
	`550`	`+ 1 - downloadModelsSize.remainingSize.toFloat() / downloadModelsSize.allSize`
	`551`	`+ }`
`547`	`552`
`548`	`553`	`val animatedProgress by animateFloatAsState(`
`549`	`554`	`targetValue = progress,`