fix: handle NoCachedDataException

Author: PavloNetrebchuk

core/src/main/java/org/openedx/core/presentation/dialog/downloaddialog/DownloadDialogManager.kt

@@ -209,51 +209,53 @@ class DownloadDialogManager(
         fragmentManager: FragmentManager,
     ) {
         coroutineScope.launch {
-            val courseIds = downloadModels.map { it.courseId }.distinct()
-            val blockIds = downloadModels.map { it.id }
-            val notDownloadedSubSections = mutableListOf<Block>()
-            val allDownloadDialogItems = mutableListOf<DownloadDialogItem>()
-
-            courseIds.forEach { courseId ->
-                val courseStructure = interactor.getCourseStructureFromCache(courseId)
-                val allSubSectionBlocks =
-                    courseStructure.blockData.filter { it.type == BlockType.SEQUENTIAL }
-
-                allSubSectionBlocks.forEach { subSectionBlock ->
-                    val verticalBlocks =
-                        courseStructure.blockData.filter { it.id in subSectionBlock.descendants }
-                    val blocks = courseStructure.blockData.filter {
-                        it.id in verticalBlocks.flatMap { it.descendants } && it.id in blockIds
-                    }
-                    val totalSize = blocks.sumOf { it.getFileSize() }
-
-                    if (blocks.isNotEmpty()) notDownloadedSubSections.add(subSectionBlock)
-                    if (totalSize > 0) {
-                        allDownloadDialogItems.add(
-                            DownloadDialogItem(
-                                title = subSectionBlock.displayName,
-                                size = totalSize
+            runCatching {
+                val courseIds = downloadModels.map { it.courseId }.distinct()
+                val blockIds = downloadModels.map { it.id }
+                val notDownloadedSubSections = mutableListOf<Block>()
+                val allDownloadDialogItems = mutableListOf<DownloadDialogItem>()
+
+                courseIds.forEach { courseId ->
+                    val courseStructure = interactor.getCourseStructureFromCache(courseId)
+                    val allSubSectionBlocks =
+                        courseStructure.blockData.filter { it.type == BlockType.SEQUENTIAL }
+
+                    allSubSectionBlocks.forEach { subSectionBlock ->
+                        val verticalBlocks =
+                            courseStructure.blockData.filter { it.id in subSectionBlock.descendants }
+                        val blocks = courseStructure.blockData.filter {
+                            it.id in verticalBlocks.flatMap { it.descendants } && it.id in blockIds
+                        }
+                        val totalSize = blocks.sumOf { it.getFileSize() }
+
+                        if (blocks.isNotEmpty()) notDownloadedSubSections.add(subSectionBlock)
+                        if (totalSize > 0) {
+                            allDownloadDialogItems.add(
+                                DownloadDialogItem(
+                                    title = subSectionBlock.displayName,
+                                    size = totalSize
+                                )
                             )
-                        )
+                        }
                     }
                 }
-            }
 
-            uiState.emit(
-                DownloadDialogUIState(
-                    downloadDialogItems = allDownloadDialogItems,
-                    isAllBlocksDownloaded = false,
-                    isDownloadFailed = true,
-                    sizeSum = allDownloadDialogItems.sumOf { it.size },
-                    fragmentManager = fragmentManager,
-                    removeDownloadModels = {},
-                    saveDownloadModels = {
-                        coroutineScope.launch {
-                            workerController.saveModels(downloadModels)
+                uiState.emit(
+                    DownloadDialogUIState(
+                        downloadDialogItems = allDownloadDialogItems,
+                        isAllBlocksDownloaded = false,
+                        isDownloadFailed = true,
+                        sizeSum = allDownloadDialogItems.sumOf { it.size },
+                        fragmentManager = fragmentManager,
+                        removeDownloadModels = {},
+                        saveDownloadModels = {
+                            coroutineScope.launch {
+                                workerController.saveModels(downloadModels)
+                            }
                         }
-                    }
+                    )
                 )
-            )
+            }
         }
     }
 

course/src/main/java/org/openedx/course/presentation/offline/CourseOfflineViewModel.kt

@@ -80,29 +80,31 @@ class CourseOfflineViewModel(
 
     fun downloadAllBlocks(fragmentManager: FragmentManager) {
         viewModelScope.launch {
-            val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
-            val downloadModels = courseInteractor.getAllDownloadModels()
-            val subSectionsBlocks = allBlocks.values.filter { it.type == BlockType.SEQUENTIAL }
-            val notDownloadedSubSectionBlocks = subSectionsBlocks.mapNotNull { subSection ->
-                val verticalBlocks = allBlocks.values.filter { it.id in subSection.descendants }
-                val notDownloadedBlocks = courseStructure.blockData.filter { block ->
-                    block.id in verticalBlocks.flatMap { it.descendants } &&
-                            block.isDownloadable &&
-                            downloadModels.none { it.id == block.id }
+            runCatching {
+                val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
+                val downloadModels = courseInteractor.getAllDownloadModels()
+                val subSectionsBlocks = allBlocks.values.filter { it.type == BlockType.SEQUENTIAL }
+                val notDownloadedSubSectionBlocks = subSectionsBlocks.mapNotNull { subSection ->
+                    val verticalBlocks = allBlocks.values.filter { it.id in subSection.descendants }
+                    val notDownloadedBlocks = courseStructure.blockData.filter { block ->
+                        block.id in verticalBlocks.flatMap { it.descendants } &&
+                                block.isDownloadable &&
+                                downloadModels.none { it.id == block.id }
+                    }
+                    if (notDownloadedBlocks.isNotEmpty()) subSection else null
                 }
-                if (notDownloadedBlocks.isNotEmpty()) subSection else null
-            }
 
-            downloadDialogManager.showPopup(
-                subSectionsBlocks = notDownloadedSubSectionBlocks,
-                courseId = courseId,
-                isBlocksDownloaded = false,
-                fragmentManager = fragmentManager,
-                removeDownloadModels = ::removeDownloadModels,
-                saveDownloadModels = { blockId ->
-                    saveDownloadModels(fileUtil.getExternalAppDir().path, courseId, blockId)
-                }
-            )
+                downloadDialogManager.showPopup(
+                    subSectionsBlocks = notDownloadedSubSectionBlocks,
+                    courseId = courseId,
+                    isBlocksDownloaded = false,
+                    fragmentManager = fragmentManager,
+                    removeDownloadModels = ::removeDownloadModels,
+                    saveDownloadModels = { blockId ->
+                        saveDownloadModels(fileUtil.getExternalAppDir().path, courseId, blockId)
+                    }
+                )
+            }
         }
     }
 
@@ -153,32 +155,38 @@ class CourseOfflineViewModel(
     }
 
     private suspend fun initDownloadFragment() {
-        val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
-        setBlocks(courseStructure.blockData)
-        allBlocks.values
-            .filter { it.type == BlockType.SEQUENTIAL }
-            .forEach { addDownloadableChildrenForSequentialBlock(it) }
+        runCatching {
+            val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
+            setBlocks(courseStructure.blockData)
+            allBlocks.values
+                .filter { it.type == BlockType.SEQUENTIAL }
+                .forEach { addDownloadableChildrenForSequentialBlock(it) }
+        }
     }
 
     private fun getOfflineData() {
         viewModelScope.launch {
-            val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
-            val totalDownloadableSize = getFilesSize(courseStructure.blockData)
-
-            if (totalDownloadableSize == 0L) return@launch
-
-            courseInteractor.getDownloadModels().collect { downloadModels ->
-                val completedDownloads =
-                    downloadModels.filter { it.downloadedState.isDownloaded && it.courseId == courseId }
-                val completedDownloadIds = completedDownloads.map { it.id }
-                val downloadedBlocks =
-                    courseStructure.blockData.filter { it.id in completedDownloadIds }
-
-                updateUIState(
-                    totalDownloadableSize,
-                    completedDownloads,
-                    downloadedBlocks
-                )
+            try {
+                val courseStructure = courseInteractor.getCourseStructureFromCache(courseId)
+                val totalDownloadableSize = getFilesSize(courseStructure.blockData)
+
+                if (totalDownloadableSize == 0L) return@launch
+
+                courseInteractor.getDownloadModels().collect { downloadModels ->
+                    val completedDownloads =
+                        downloadModels.filter { it.downloadedState.isDownloaded && it.courseId == courseId }
+                    val completedDownloadIds = completedDownloads.map { it.id }
+                    val downloadedBlocks =
+                        courseStructure.blockData.filter { it.id in completedDownloadIds }
+
+                    updateUIState(
+                        totalDownloadableSize,
+                        completedDownloads,
+                        downloadedBlocks
+                    )
+                }
+            } catch (e: Exception) {
+                e.printStackTrace()
             }
         }
     }