fix: changes according code review

PavloNetrebchuk · PavloNetrebchuk · commit 6025448ca2e5 · 2025-04-03T13:09:29.000+03:00
diff --git a/discussion/src/main/java/org/openedx/discussion/presentation/responses/DiscussionResponsesFragment.kt b/discussion/src/main/java/org/openedx/discussion/presentation/responses/DiscussionResponsesFragment.kt
@@ -220,6 +220,7 @@ private fun DiscussionResponsesScreen(
     val firstVisibleIndex = remember {
         mutableIntStateOf(scrollState.firstVisibleItemIndex)
     }
+    val isShouldLoadMore = scrollState.shouldLoadMore(firstVisibleIndex, LOAD_MORE_THRESHOLD)
     val pullRefreshState =
         rememberPullRefreshState(refreshing = refreshing, onRefresh = { onSwipeRefresh() })
 
@@ -421,11 +422,7 @@ private fun DiscussionResponsesScreen(
                                             }
                                         }
                                     }
-                                    if (scrollState.shouldLoadMore(
-                                            firstVisibleIndex,
-                                            LOAD_MORE_THRESHOLD
-                                        )
-                                    ) {
+                                    if (isShouldLoadMore) {
                                         paginationCallBack()
                                     }
                                 }

Original file line number	Diff line number	Diff line change
`@@ -220,6 +220,7 @@ private fun DiscussionResponsesScreen(`
`220`	`220`	`val firstVisibleIndex = remember {`
`221`	`221`	`mutableIntStateOf(scrollState.firstVisibleItemIndex)`
`222`	`222`	`}`
	`223`	`+ val isShouldLoadMore = scrollState.shouldLoadMore(firstVisibleIndex, LOAD_MORE_THRESHOLD)`
`223`	`224`	`val pullRefreshState =`
`224`	`225`	`rememberPullRefreshState(refreshing = refreshing, onRefresh = { onSwipeRefresh() })`
`225`	`226`
`@@ -421,11 +422,7 @@ private fun DiscussionResponsesScreen(`
`421`	`422`	`}`
`422`	`423`	`}`
`423`	`424`	`}`
`424`		`- if (scrollState.shouldLoadMore(`
`425`		`- firstVisibleIndex,`
`426`		`- LOAD_MORE_THRESHOLD`
`427`		`- )`
`428`		`- ) {`
	`425`	`+ if (isShouldLoadMore) {`
`429`	`426`	`paginationCallBack()`
`430`	`427`	`}`
`431`	`428`	`}`