Skip to content

Conversation

@PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Mar 5, 2025

Summary
This PR introduces a new enrollments screen that displays a list of user courses along with download functionality and responsive UI variations.

User Enrollments Screen:
• Displays a list of user enrollments with each course card showing a Banner, Title, Content Size, and a Download button.
Download UI Enhancements:
• Progress Bar: Appears when any part of the course content is downloaded, providing real-time download status.
• 3-Dots Menu: Visible on partially downloaded content, offering a dropdown with options to cancel the download or remove downloaded content.
Consistent Design & Reusability:
• The download dialogs are reused from the course screen, ensuring consistency across the application.
Responsive Design:
• Fully implemented in light mode, dark mode, tablet view, and landscape variations.


Light Dark Landscape Tablet
Screenshot 2025-03-17 at 15 07 19 Screenshot 2025-03-17 at 15 07 44 Screenshot 2025-03-17 at 15 08 14 Screenshot 2025-03-17 at 15 09 10

Partially or fully downloaded course Downloading
Screenshot 2025-03-17 at 15 20 50 Screenshot 2025-03-17 at 15 21 12

Screen.Recording.2025-03-17.at.15.24.08.mov

UPD: All download dialogs show course item with "School" icon from Material Design.

Screenshot 2025-03-21 at 13 05 18Screenshot 2025-03-21 at 13 05 54Screenshot 2025-03-21 at 13 06 09
Screenshot 2025-03-21 at 13 07 11Screenshot 2025-03-21 at 13 08 02Screenshot 2025-03-21 at 13 08 45

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 5, 2025

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/downloads_page branch 2 times, most recently from be5587a to 98c52d9 Compare March 6, 2025 11:20
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 6, 2025
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/downloads_page branch 2 times, most recently from 80583bd to 0f86d09 Compare March 18, 2025 12:35
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 19, 2025
@edschema
Copy link

This looks great from a product perspective. One small note: for course downloads, the icon for courses should be consistent between iOS and Android. Can we change these icons to the "School" icon from Material Design?

Confirm Dialog
image

@PavloNetrebchuk
Copy link
Contributor Author

@edschema Thank you for your feedback. The changes have already been made.

@PavloNetrebchuk PavloNetrebchuk marked this pull request as ready for review March 25, 2025 12:19
k1rill
k1rill previously approved these changes Mar 31, 2025
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome work, just one little nit


suspend fun getCourseStructure(courseId: String): CourseStructure {
try {
val response = api.getCourseStructure(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it's better to used named arguments here

@volodymyr-chekyrta volodymyr-chekyrta merged commit d659f71 into openedx:develop Apr 1, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 1, 2025
@PavloNetrebchuk PavloNetrebchuk deleted the feat/downloads_page branch April 1, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants