-
Notifications
You must be signed in to change notification settings - Fork 46
feat: [FC-0078] Downloads page #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0078] Downloads page #432
Conversation
|
Thanks for the pull request, @PavloNetrebchuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
9e710b0 to
2e4ce9d
Compare
be5587a to
98c52d9
Compare
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsViewModel.kt
Fixed
Show fixed
Hide fixed
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsViewModel.kt
Fixed
Show fixed
Hide fixed
98c52d9 to
b4e6241
Compare
core/src/main/java/org/openedx/core/presentation/dialog/downloaddialog/DownloadDialogManager.kt
Fixed
Show fixed
Hide fixed
core/src/main/java/org/openedx/core/presentation/dialog/downloaddialog/DownloadDialogManager.kt
Fixed
Show fixed
Hide fixed
course/src/main/java/org/openedx/course/presentation/videos/CourseVideoViewModel.kt
Show resolved
Hide resolved
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsFragment.kt
Outdated
Show resolved
Hide resolved
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsFragment.kt
Outdated
Show resolved
Hide resolved
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsFragment.kt
Outdated
Show resolved
Hide resolved
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsFragment.kt
Outdated
Show resolved
Hide resolved
downloads/src/main/java/org/openedx/downloads/presentation/download/DownloadsViewModel.kt
Outdated
Show resolved
Hide resolved
52f3d59 to
32897ab
Compare
80583bd to
0f86d09
Compare
0f86d09 to
d0288bd
Compare
… getting downloads models from room
|
@edschema Thank you for your feedback. The changes have already been made. |
5461997 to
b029359
Compare
fc998d5 to
a0fbad8
Compare
k1rill
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome work, just one little nit
|
|
||
| suspend fun getCourseStructure(courseId: String): CourseStructure { | ||
| try { | ||
| val response = api.getCourseStructure( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it's better to used named arguments here
7663c59 to
e665d9c
Compare

Summary
This PR introduces a new enrollments screen that displays a list of user courses along with download functionality and responsive UI variations.
User Enrollments Screen:
• Displays a list of user enrollments with each course card showing a Banner, Title, Content Size, and a Download button.
Download UI Enhancements:
• Progress Bar: Appears when any part of the course content is downloaded, providing real-time download status.
• 3-Dots Menu: Visible on partially downloaded content, offering a dropdown with options to cancel the download or remove downloaded content.
Consistent Design & Reusability:
• The download dialogs are reused from the course screen, ensuring consistency across the application.
Responsive Design:
• Fully implemented in light mode, dark mode, tablet view, and landscape variations.
Screen.Recording.2025-03-17.at.15.24.08.mov
UPD: All download dialogs show course item with "School" icon from Material Design.