Skip to content

Conversation

@PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Apr 7, 2025

Fixed upgrade item on SettingsFragment, moved upgrade popup to MainFragment
openedx/openedx-app-ios#449


Soft

Screen.Recording.2025-04-07.at.17.16.31.mov

Forse

Screen.Recording.2025-04-07.at.17.19.09.mov

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 7, 2025

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 7, 2025
@PavloNetrebchuk PavloNetrebchuk force-pushed the fix/soft_and_forse_update_fix branch from edaa642 to 40aea97 Compare April 7, 2025 10:35
@PavloNetrebchuk PavloNetrebchuk force-pushed the fix/soft_and_forse_update_fix branch from 40aea97 to e21aa42 Compare April 7, 2025 10:46
@PavloNetrebchuk PavloNetrebchuk changed the title Soft and Forse upgrade fix fix: [FC-0078] Soft and Forse upgrade fix Apr 7, 2025
@PavloNetrebchuk PavloNetrebchuk self-assigned this Apr 7, 2025
@PavloNetrebchuk PavloNetrebchuk marked this pull request as ready for review April 7, 2025 14:36
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Apr 7, 2025
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Apr 7, 2025
Copy link
Contributor

@k1rill k1rill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@volodymyr-chekyrta volodymyr-chekyrta merged commit 9014e63 into openedx:develop Apr 9, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Apr 9, 2025
@PavloNetrebchuk PavloNetrebchuk deleted the fix/soft_and_forse_update_fix branch April 9, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants