Skip to content

Conversation

@PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Jul 9, 2025

Added a progress screen to display user’s course and assignment completion status
Support RTL and A11Y

In that PR, color coding is mocked. It will work correctly once the backend returns the color list.
val defaultColors = listOf("#fe553a", "#32c0ff", "#a3ff7b", "#ff30ee")

Light Dark
Screenshot 2025-07-18 at 13 30 08 Screenshot 2025-07-18 at 13 30 35
Screenshot 2025-07-18 at 13 31 22Screenshot 2025-07-18 at 13 31 55 Screenshot 2025-07-18 at 13 32 16Screenshot 2025-07-18 at 13 32 24
Screenshot 2025-07-18 at 13 34 48 Screenshot 2025-07-18 at 13 34 59

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 9, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 9, 2025

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PavloNetrebchuk PavloNetrebchuk marked this pull request as draft July 9, 2025 10:11
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Detekt issues as well.

@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/progress_tab branch 4 times, most recently from 51779d8 to b535314 Compare July 11, 2025 09:42
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , we can proceed with testing and external review of this PR.

…gress_tab

# Conflicts:
#	course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt
@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jul 15, 2025
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/progress_tab branch 2 times, most recently from 2cdcc80 to 8e4bc7b Compare July 18, 2025 10:22
@PavloNetrebchuk PavloNetrebchuk marked this pull request as ready for review July 18, 2025 10:35
@PavloNetrebchuk PavloNetrebchuk force-pushed the feat/progress_tab branch 2 times, most recently from 7a50a03 to 8703fd2 Compare July 21, 2025 17:11
@edschema
Copy link

Android PR associated with Issue: Course Progress Page #625

@edschema
Copy link

edschema commented Aug 4, 2025

Screenshots look good. Passed to community code review July 31

Copy link

@RawanMatar89 RawanMatar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SerializedName("grade_range") val gradeRange: Map<String, Float>?,
@SerializedName("assignment_colors") val assignmentColors: List<String>?
) {
// Temporary solution. Backend will returns color list later

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add TODO here

@volodymyr-chekyrta volodymyr-chekyrta merged commit 4df0b02 into openedx:develop Aug 18, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Aug 18, 2025
@volodymyr-chekyrta volodymyr-chekyrta deleted the feat/progress_tab branch August 18, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants