-
Notifications
You must be signed in to change notification settings - Fork 46
feat: [FC-0092] Course progress tab #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0092] Course progress tab #448
Conversation
|
Thanks for the pull request, @PavloNetrebchuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt
Fixed
Show fixed
Hide fixed
core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt
Fixed
Show fixed
Hide fixed
core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt
Fixed
Show fixed
Hide fixed
core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt
Fixed
Show fixed
Hide fixed
core/src/main/java/org/openedx/core/data/model/room/CourseProgressEntity.kt
Fixed
Show fixed
Hide fixed
course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt
Fixed
Show fixed
Hide fixed
course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt
Fixed
Show fixed
Hide fixed
course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt
Fixed
Show fixed
Hide fixed
volodymyr-chekyrta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address Detekt issues as well.
core/src/main/java/org/openedx/core/domain/model/CourseProgress.kt
Outdated
Show resolved
Hide resolved
51779d8 to
b535314
Compare
b535314 to
2ffa9df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 , we can proceed with testing and external review of this PR.
2ffa9df to
c21c1bd
Compare
…gress_tab # Conflicts: # course/src/main/java/org/openedx/course/presentation/progress/CourseProgressScreen.kt
c21c1bd to
da8c768
Compare
2cdcc80 to
8e4bc7b
Compare
7a50a03 to
8703fd2
Compare
|
Android PR associated with Issue: Course Progress Page #625 |
8703fd2 to
924461f
Compare
4b02e71 to
381b8b3
Compare
|
Screenshots look good. Passed to community code review July 31 |
RawanMatar89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @SerializedName("grade_range") val gradeRange: Map<String, Float>?, | ||
| @SerializedName("assignment_colors") val assignmentColors: List<String>? | ||
| ) { | ||
| // Temporary solution. Backend will returns color list later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add TODO here
8c9d166 to
eafcd7b
Compare
core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt
Fixed
Show fixed
Hide fixed
eafcd7b to
331c5e0
Compare
Added a progress screen to display user’s course and assignment completion status
Support RTL and A11Y
In that PR, color coding is mocked. It will work correctly once the backend returns the color list.
val defaultColors = listOf("#fe553a", "#32c0ff", "#a3ff7b", "#ff30ee")