feat: [FC-0092] Course content tabs #450

PavloNetrebchuk · 2025-07-18T12:03:13Z

All tab

Light	Dark

Videos tab

Light	Dark

Assignments tab

Light	Dark

Also was added resuming videos from where the user left off:

Screen.Recording.2025-07-23.at.14.11.22.mov

openedx-webhooks · 2025-07-18T12:03:17Z

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

core/src/main/java/org/openedx/core/data/model/AssignmentProgress.kt

core/src/main/java/org/openedx/core/utils/PreviewHelper.kt

course/src/main/java/org/openedx/course/presentation/contenttab/ContentTabScreen.kt

course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt

course/src/main/java/org/openedx/course/presentation/videos/CourseContentVideoScreen.kt

core/src/main/java/org/openedx/core/data/model/AssignmentProgress.kt

...e/src/main/java/org/openedx/course/presentation/assignments/CourseContentAssignmentScreen.kt

course/src/test/java/org/openedx/course/presentation/videos/CourseVideoViewModelTest.kt

core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt

volodymyr-chekyrta

Please address feedback

core/src/main/java/org/openedx/core/data/model/room/VideoProgressEntity.kt

core/src/main/java/org/openedx/core/domain/model/Block.kt

core/src/main/java/org/openedx/core/utils/PreviewHelper.kt

course/src/main/java/org/openedx/course/presentation/assignments/CourseAssignmentViewModel.kt

course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt

course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitFragment.kt

course/src/main/java/org/openedx/course/presentation/videos/CourseVideoViewModel.kt

gradle.properties

core/src/main/java/org/openedx/core/utils/PreviewHelper.kt

course/src/main/java/org/openedx/course/presentation/assignments/CourseAssignmentViewModel.kt

course/src/main/java/org/openedx/course/presentation/contenttab/ContentTabEmptyState.kt

core/src/main/java/org/openedx/core/utils/PreviewHelper.kt

volodymyr-chekyrta

LGTM 👍 , we can proceed with testing and external review of this PR.

edschema · 2025-08-20T22:42:17Z

Added notes to the related iOS PR that are relevant here as well:
openedx/openedx-app-ios#630

PavloNetrebchuk · 2025-08-21T16:15:46Z

@edschema

Done👍

course/src/test/java/org/openedx/course/presentation/videos/CourseVideoViewModelTest.kt

RawanMatar89

Same as iOS, great work on this!
LGTM ✅

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 18, 2025

openedx-webhooks added this to Contributions Jul 18, 2025

github-project-automation bot moved this to Needs Triage in Contributions Jul 18, 2025

github-advanced-security bot found potential problems Jul 18, 2025

View reviewed changes

core/src/main/java/org/openedx/core/data/model/AssignmentProgress.kt Fixed Show fixed Hide fixed

PavloNetrebchuk force-pushed the feat/content_tab branch 2 times, most recently from 2de3323 to 86fcc9c Compare July 18, 2025 15:18

github-advanced-security bot found potential problems Jul 18, 2025

View reviewed changes

...e/src/main/java/org/openedx/course/presentation/assignments/CourseContentAssignmentScreen.kt Fixed Show fixed Hide fixed

PavloNetrebchuk force-pushed the feat/content_tab branch from 86fcc9c to 19bb326 Compare July 18, 2025 15:31

github-advanced-security bot found potential problems Jul 18, 2025

View reviewed changes

...e/src/main/java/org/openedx/course/presentation/assignments/CourseContentAssignmentScreen.kt Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems Jul 23, 2025

View reviewed changes

course/src/test/java/org/openedx/course/presentation/videos/CourseVideoViewModelTest.kt Fixed Show fixed Hide fixed

PavloNetrebchuk force-pushed the feat/content_tab branch 4 times, most recently from 797a994 to 19ce672 Compare July 24, 2025 10:00

volodymyr-chekyrta reviewed Jul 28, 2025

View reviewed changes

core/src/main/java/org/openedx/core/data/model/CourseProgressResponse.kt Show resolved Hide resolved

volodymyr-chekyrta requested changes Jul 28, 2025

View reviewed changes

PavloNetrebchuk force-pushed the feat/content_tab branch from a090c8b to a7073d4 Compare July 28, 2025 18:12

github-advanced-security bot found potential problems Jul 28, 2025

View reviewed changes

PavloNetrebchuk force-pushed the feat/content_tab branch 3 times, most recently from ac69628 to 63a83e3 Compare July 28, 2025 19:22

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 28, 2025

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jul 28, 2025

PavloNetrebchuk force-pushed the feat/content_tab branch from 1c1eac1 to 63a83e3 Compare July 29, 2025 09:53

github-advanced-security bot found potential problems Jul 29, 2025

View reviewed changes

volodymyr-chekyrta requested changes Jul 30, 2025

View reviewed changes

core/src/main/java/org/openedx/core/utils/PreviewHelper.kt Outdated Show resolved Hide resolved

volodymyr-chekyrta previously approved these changes Jul 31, 2025

View reviewed changes

PavloNetrebchuk marked this pull request as ready for review July 31, 2025 09:28

PavloNetrebchuk added 8 commits August 19, 2025 13:14

feat: color coding, detekt fixes

515a4d9

feat: resume video

7cc4182

fix: changes according review

bf564c8

feat: changes according PR feedback

9f0ae15

feat: empty state view

0519fa9

fix: changes according PR review feedback

e5311f5

fix: changes according QA review feedback

d8614c0

feat: analytics

44f4f4e

PavloNetrebchuk force-pushed the feat/content_tab branch from 3f8da5f to cab6e27 Compare August 19, 2025 10:14

PavloNetrebchuk force-pushed the feat/content_tab branch from cab6e27 to 94b5bfd Compare August 21, 2025 09:50

PavloNetrebchuk force-pushed the feat/content_tab branch 2 times, most recently from 2df594f to 87b3f42 Compare August 22, 2025 08:54

github-advanced-security bot found potential problems Aug 22, 2025

View reviewed changes

course/src/test/java/org/openedx/course/presentation/videos/CourseVideoViewModelTest.kt Fixed Show fixed Hide fixed

PavloNetrebchuk force-pushed the feat/content_tab branch 4 times, most recently from ea8c616 to 7c3bd70 Compare August 22, 2025 11:27

volodymyr-chekyrta requested a review from RawanMatar89 August 27, 2025 09:23

edschema mentioned this pull request Aug 28, 2025

[FC-0092] Course Content View (Videos Tab Improvement) openedx/openedx-app-ios#429

Closed

fix: changes according QA review

98c7afe

PavloNetrebchuk force-pushed the feat/content_tab branch from 7c3bd70 to 98c7afe Compare August 29, 2025 12:31

RawanMatar89 approved these changes Aug 30, 2025

View reviewed changes

feat: db automigration

4d245e4

volodymyr-chekyrta approved these changes Sep 1, 2025

View reviewed changes

volodymyr-chekyrta merged commit 8de8a4d into openedx:develop Sep 1, 2025
6 checks passed

github-project-automation bot moved this from Waiting on Author to Done in Contributions Sep 1, 2025

volodymyr-chekyrta deleted the feat/content_tab branch September 1, 2025 09:18

PavloNetrebchuk mentioned this pull request Oct 23, 2025

Release v2.2 (Ulmo.1) #465

Merged

feat: [FC-0092] Course content tabs #450

feat: [FC-0092] Course content tabs #450

Uh oh!

Conversation

PavloNetrebchuk commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

Uh oh!

edschema commented Aug 20, 2025

Uh oh!

PavloNetrebchuk commented Aug 21, 2025

Uh oh!

Uh oh!

RawanMatar89 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

PavloNetrebchuk commented Jul 18, 2025 •

edited

Loading

openedx-webhooks commented Jul 18, 2025 •

edited

Loading