Memory Leak Fix: ViewPager2 Fragment Management #453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Memory leaks detected across all MainFragment pager screens (LearnFragment, ProgramFragment, NativeDiscoveryFragment, DashboardGalleryFragment, DownloadsFragment, ProfileFragment) due to improper fragment lifecycle management in ViewPager2.
Root Cause
NavigationFragmentAdapter was storing strong references to Fragment instances in ArrayList, preventing garbage collection when fragments were destroyed.
Changes
NavigationFragmentAdapter: Use fragment factories instead of storing instances
MainFragment: Updated to use factory pattern and added adapter cleanup
LearnFragment: Applied same pattern with proper cleanup
Benefits
✅ Eliminates memory leaks across all pager screens
✅ Proper fragment lifecycle management
✅ Lazy fragment creation (only when needed)
✅ Better performance and memory usage
Testing
Memory profiler shows no more leaks in MainFragment pager screens.