feat: [FC-0092]: Video navigation #464
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @PavloNetrebchuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Fixed
Show fixed
Hide fixed
.../src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
Fixed
Show fixed
Hide fixed
IvanStepanok
left a comment
IvanStepanok
left a comment
There was a problem hiding this comment.
LGTM
just update the tests
PavloNetrebchuk
force-pushed
the
feat/video_navigation
branch
2 times, most recently
from
5dca699 to
e8ee9ca
Compare
course/src/main/java/org/openedx/course/presentation/unit/container/CourseViewMode.kt
Fixed
Show fixed
Hide fixed
course/src/main/java/org/openedx/course/presentation/unit/container/CourseViewMode.kt
Fixed
Show fixed
Hide fixed
PavloNetrebchuk
force-pushed
the
feat/video_navigation
branch
from
e8ee9ca to
ac10f8c
Compare
# Conflicts: # course/src/main/java/org/openedx/course/presentation/ui/CourseUI.kt # course/src/main/java/org/openedx/course/presentation/unit/container/CourseUnitContainerFragment.kt
PavloNetrebchuk
force-pushed
the
feat/video_navigation
branch
from
01a2d06 to
5f23bf3
Compare
volodymyr-chekyrta
changed the title
PavloNetrebchuk
force-pushed
the
feat/video_navigation
branch
from
e8b13cd to
795c43e
Compare
| val courseId: String, | ||
| val unitId: String, | ||
| val mode: CourseViewMode, | ||
| private val context: Context, |
There was a problem hiding this comment.
Can we avoid injecting context directly into the ViewModel?
There was a problem hiding this comment.
I don't sure. Or that way, or loading video previews on UI
There was a problem hiding this comment.
Could we convert PreviewHelper from an object to a class and inject Context into it, so that we can provide a PreviewHelper instance from DI where it is needed?
Let me know what you think about this.
PavloNetrebchuk
force-pushed
the
feat/video_navigation
branch
from
baeffc4 to
63fd961
Compare
github-project-automation
bot
moved this from Waiting on Author
to Done
in Contributions
5 participants
Added video navigation list:
Screen.Recording.2025-10-08.at.12.41.27.mov