chore: reusing mocks #469
chore: reusing mocks #469
Conversation
|
Thanks for the pull request, @PavloNetrebchuk! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
| isEnrolled = false | ||
| ) | ||
|
|
||
| fun courses(count: Int) = List(count) { course } |
There was a problem hiding this comment.
courses(count) returns the same Course instance with identical IDs for every element
There was a problem hiding this comment.
This solution is used for preview, so it does not affect us
| val courseDateBlock = CourseDateBlock( | ||
| complete = false, | ||
| date = Date(), | ||
| dateType = DateType.TODAY_DATE, | ||
| description = "Mocked Course Date Description" | ||
| ) | ||
|
|
||
| val courseDateBlocks = linkedMapOf( | ||
| Pair(DatesSection.COMPLETED, listOf(courseDateBlock, courseDateBlock)), | ||
| Pair(DatesSection.PAST_DUE, listOf(courseDateBlock, courseDateBlock)), | ||
| Pair(DatesSection.TODAY, listOf(courseDateBlock, courseDateBlock)) | ||
| ) |
There was a problem hiding this comment.
Is the date always the same?
There was a problem hiding this comment.
Yes, but it also does not affect anything.
In some specific cases, we can use the copy() function to create an object with the date we need.
4 participants
Change Size:
58 files changed; 1172 insertions, 2685 deletions.
The size of the project has decreased by 1,513 lines.