chore: refactor uiMessage flow #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

PavloNetrebchuk wants to merge 42 commits into openedx:develop from raccoongang:chore/uimessage_refactoring

Contributor

PavloNetrebchuk commented Dec 15, 2025

Refactored UI message flow and error handling to align with foundation library changes, making the code cleaner, simpler, and more reusable.

PavloNetrebchuk added 19 commits

December 4, 2025 16:20


          feat: dates tab UI

99d4cbc


          feat: added config flag for enabling/disabling dates screen

c3dba4d


          feat: pull to refresh


          feat: offline mode dialog

b12d92d


          feat: added dates request

f03bec6


          feat: paging and caching

5ed6582


          feat: navigating to block


          feat: reuse dates UI from CourseDatesScreen

56ef429


          feat: shift due date card

4c50c52


          feat: shift due date request

582e2c6


          feat: junit tests

cce080d


          feat: junit tests and analytics

62a96ff


          fix: changes according detekt warnings

3e9bb00


          feat: pagination

3a904c2


          fix: pagination bugs

7ecaa33


          feat: cache-first logic

894a206


          fix: changes according code review

abaa25a


          feat: according designer feedback

b881a1d


          fix: assignment default color fix

a0d9ea5

openedx-webhooks added the open-source-contribution label

openedx-webhooks commented Dec 15, 2025

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

openedx-webhooks added this to Contributions

github-project-automation bot moved this to Needs Triage in Contributions

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

PavloNetrebchuk force-pushed the chore/uimessage_refactoring branch 2 times, most recently from 6567269 to af5140d Compare

December 15, 2025 19:42

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions


          fix: empty state icon

058b847

PavloNetrebchuk force-pushed the chore/uimessage_refactoring branch from af5140d to aed3193 Compare

December 18, 2025 12:23


          feat: dates tab UI

4d0483e

PavloNetrebchuk added 20 commits

December 18, 2025 14:25


          feat: added config flag for enabling/disabling dates screen


          feat: pull to refresh

51bb67d


          feat: offline mode dialog

d9fc9bf


          feat: added dates request

ae40ff1


          feat: paging and caching

ef9de7e


          feat: navigating to block

65a6667


          feat: reuse dates UI from CourseDatesScreen

2a61eb9


          feat: shift due date card

e692b98


          feat: shift due date request

1d31569


          feat: junit tests

60809a1


          feat: junit tests and analytics

55e168e


          fix: changes according detekt warnings

cd61dcd


          feat: pagination

cf52207


          fix: pagination bugs

1e36b5f


          feat: cache-first logic

76737e2


          fix: changes according code review

1cdbb3e


          feat: according designer feedback

d010479


          fix: assignment default color fix

8dea508


          fix: empty state icon

ed7ebdc


          chore: refactor uiMessage flow

b754a66

PavloNetrebchuk force-pushed the chore/uimessage_refactoring branch from aed3193 to b754a66 Compare

December 18, 2025 12:37


          Merge branch 'feat/dates_page' into chore/uimessage_refactoring

87d5fae

# Conflicts:
#	core/src/main/java/org/openedx/core/presentation/dates/DatesUI.kt
#	dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt
#	dates/src/test/java/org/openedx/dates/DatesViewModelTest.kt

github-advanced-security bot found potential problems

View reviewed changes

core/src/main/java/org/openedx/core/presentation/dates/DatesUI.kt

+              import org.openedx.core.utils.TimeUtils.formatToString
+              import org.openedx.core.utils.clearTime
+              import org.openedx.core.utils.isToday
+              import java.util.Date

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import androidx.fragment.app.FragmentManager
+              import androidx.lifecycle.viewModelScope
+              import kotlinx.coroutines.Job
+              import kotlinx.coroutines.flow.MutableSharedFlow

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import kotlinx.coroutines.Job
+              import kotlinx.coroutines.flow.MutableSharedFlow
+              import kotlinx.coroutines.flow.MutableStateFlow
+              import kotlinx.coroutines.flow.SharedFlow

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import kotlinx.coroutines.flow.MutableStateFlow
+              import kotlinx.coroutines.flow.SharedFlow
+              import kotlinx.coroutines.flow.StateFlow
+              import kotlinx.coroutines.flow.asSharedFlow

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import kotlinx.coroutines.flow.asStateFlow
+              import kotlinx.coroutines.flow.update
+              import kotlinx.coroutines.launch
+              import org.openedx.core.R

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import org.openedx.dates.presentation.DatesAnalyticsEvent
+              import org.openedx.dates.presentation.DatesAnalyticsKey
+              import org.openedx.dates.presentation.DatesRouter
+              import org.openedx.foundation.extension.isInternetError

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/main/java/org/openedx/dates/presentation/dates/DatesViewModel.kt

+              import org.openedx.dates.presentation.DatesRouter
+              import org.openedx.foundation.extension.isInternetError
+              import org.openedx.foundation.presentation.BaseViewModel
+              import org.openedx.foundation.presentation.UIMessage

Check warning

Code scanning / detekt

Detects unused imports Warning

Unused import

dates/src/test/java/org/openedx/dates/DatesViewModelTest.kt

+              import org.junit.Before
+              import org.junit.Rule
+              import org.junit.Test
+              import org.openedx.core.R

Check warning

Code scanning / detekt

Detects unused imports Warning test

Unused import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution