fixup! fixup! feat: New User Agreements API

Author: xitij2000

openedx/core/djangoapps/agreements/serializers.py

@@ -4,7 +4,10 @@
 
 from rest_framework import serializers
 
-from openedx.core.djangoapps.agreements.models import IntegritySignature, LTIPIISignature
+from openedx.core.djangoapps.agreements.models import (
+    IntegritySignature, LTIPIISignature, UserAgreement,
+    UserAgreementRecord
+)
 from openedx.core.lib.api.serializers import CourseKeyField
 
 
@@ -34,25 +37,22 @@ class Meta:
         fields = ('username', 'course_id', 'lti_tools', 'created_at')
 
 
-class UserAgreementSerializer(serializers.Serializer):
+class UserAgreementSerializer(serializers.ModelSerializer):
     """
     Serializer for UserAgreement model
     """
 
-    type = serializers.CharField(read_only=True)
-    name = serializers.CharField(read_only=True)
-    summary = serializers.CharField(read_only=True)
-    has_text = serializers.BooleanField(read_only=True)
-    url = serializers.URLField(read_only=True)
-    updated = serializers.DateTimeField(read_only=True)
+    class Meta:
+        model = UserAgreement
+        read_only_fields = ('type', 'name', 'summary', 'has_text', 'url', 'updated')
 
 
-class UserAgreementRecordSerializer(serializers.Serializer):
+class UserAgreementRecordSerializer(serializers.ModelSerializer):
     """
     Serializer for UserAgreementRecord model
     """
 
-    username = serializers.CharField(read_only=True)
-    agreement_type = serializers.CharField(read_only=True)
-    accepted_at = serializers.DateTimeField()
-    is_current = serializers.BooleanField(read_only=True)
+    class Meta:
+        model = UserAgreementRecord
+        fields = ('username', 'agreement_type', 'accepted_at', 'is_current')
+        read_only_fields = ('username', 'agreement_type', 'is_current')

openedx/core/djangoapps/agreements/toggles.py

@@ -19,7 +19,6 @@
 
 ENABLE_LTI_PII_ACKNOWLEDGEMENT = CourseWaffleFlag('agreements.enable_lti_pii_acknowledgement', __name__)
 
-
 def lti_pii_acknowledgment_enabled(course_key):
     """
     Returns a boolean if lti pii acknowledgements are enabled for a course.

openedx/core/djangoapps/agreements/urls.py

@@ -23,6 +23,6 @@
     re_path(r'^lti_pii_signature/{course_id}$'.format(
         course_id=settings.COURSE_ID_PATTERN
     ), LTIPIISignatureView.as_view(), name='lti_pii_signature'),
-    path("agreement_record/<slug:agreement_type>", UserAgreementRecordsView.as_view(), name="user_agreement_record"),
-    path("", include(router.urls)),
+    path('agreement_record/<slug:agreement_type>', UserAgreementRecordsView.as_view(), name='user_agreement_record'),
+    path('', include(router.urls)),
 ]