fix: lint issues

Author: navinkarkera

cms/djangoapps/contentstore/rest_api/v2/views/tests/test_downstreams.py

@@ -11,7 +11,7 @@
 from organizations.models import Organization
 
 from cms.djangoapps.contentstore.helpers import StaticFileNotices
-from cms.lib.xblock.upstream_sync import BadUpstream, UpstreamLink
+from cms.lib.xblock.upstream_sync import BadUpstream, ComponentUpstreamSyncManager, UpstreamLink
 from cms.djangoapps.contentstore.tests.utils import CourseTestCase
 from opaque_keys.edx.keys import UsageKey
 from common.djangoapps.student.tests.factories import UserFactory
@@ -235,7 +235,7 @@ def call_api(self, usage_key_string, sync: str | None = None):
             content_type="application/json",
         )
 
-    @patch.object(downstreams_views, "fetch_customizable_fields")
+    @patch.object(ComponentUpstreamSyncManager, "update_customizable_fields")
     @patch.object(downstreams_views, "sync_from_upstream")
     @patch.object(UpstreamLink, "get_for_block", _get_upstream_link_good_and_syncable)
     def test_200_with_sync(self, mock_sync, mock_fetch):
@@ -250,7 +250,7 @@ def test_200_with_sync(self, mock_sync, mock_fetch):
         assert mock_fetch.call_count == 0
         assert video_after.upstream == self.video_lib_id
 
-    @patch.object(downstreams_views, "fetch_customizable_fields")
+    @patch.object(ComponentUpstreamSyncManager, "update_customizable_fields")
     @patch.object(downstreams_views, "sync_from_upstream")
     @patch.object(UpstreamLink, "get_for_block", _get_upstream_link_good_and_syncable)
     def test_200_no_sync(self, mock_sync, mock_fetch):
@@ -265,7 +265,11 @@ def test_200_no_sync(self, mock_sync, mock_fetch):
         assert mock_fetch.call_count == 1
         assert video_after.upstream == self.video_lib_id
 
-    @patch.object(downstreams_views, "fetch_customizable_fields", side_effect=BadUpstream(MOCK_UPSTREAM_ERROR))
+    @patch.object(
+        ComponentUpstreamSyncManager,
+        "update_customizable_fields",
+        side_effect=BadUpstream(MOCK_UPSTREAM_ERROR)
+    )
     def test_400(self, sync: str):
         """
         Do we raise a 400 if the provided upstream reference is malformed or not accessible?

openedx/core/djangoapps/xblock/learning_context/learning_context.py

@@ -40,7 +40,11 @@ def can_edit_block(self, user: UserType, usage_key: LibraryUsageLocatorV2 | Libr
         """
         return False
 
-    def can_view_block_for_editing(self, user: UserType, usage_key: LibraryUsageLocatorV2 | LibraryContainerLocator) -> bool:
+    def can_view_block_for_editing(
+        self,
+        user: UserType,
+        usage_key: LibraryUsageLocatorV2 | LibraryContainerLocator,
+    ) -> bool:
         """
         Assuming a block with the specified ID (usage_key) exists, does the
         specified user have permission to view its fields and OLX details (but

openedx/core/djangoapps/xblock/learning_context/manager.py

@@ -35,7 +35,7 @@ def get_learning_context_impl(key):
     """
     if isinstance(key, LearningContextKey):
         context_type = key.CANONICAL_NAMESPACE  # e.g. 'lib'
-    elif isinstance(key, UsageKeyV2) or isinstance(key, LibraryItemKey):
+    elif isinstance(key, (UsageKeyV2, LibraryItemKey)):
         context_type = key.context_key.CANONICAL_NAMESPACE
     elif isinstance(key, OpaqueKey):
         # Maybe this is an older modulestore key etc.

openedx/core/djangoapps/xblock/runtime/learning_core_runtime.py

@@ -167,6 +167,9 @@ class LearningCoreXBlockRuntime(XBlockRuntime):
     """
 
     def _initialize_block(self, content, usage_key, block_type, version: int | LatestVersion):
+        """
+        Creates new xblock from given content, usage_key and block_type
+        """
         xml_node = etree.fromstring(content)
         keys = ScopeIds(self.user_id, block_type, None, usage_key)