Skip to content

Conversation

@Alec4r
Copy link
Contributor

@Alec4r Alec4r commented May 12, 2025

πŸš€ Description

This PR introduces the initial setup and functionality for the tutor-contrib-paragon plugin.

βœ… Summary of changes

1. chore: add CI workflow and local development tooling

  • Adds a GitHub Actions CI workflow that runs only when changes are made in the plugin's directory (supports monorepo structure).

  • Includes local development tools:

    • pytest for future test coverage
    • Makefile targets for development (make run-tests, make dev-requirements, etc.)

2. feat: create theme folders from config and document structure

  • Adds logic to automatically create the following folders based on Tutor config values:

    • PARAGON_THEME_SOURCES_PATH β†’ where theme source files (Style Dictionary) are placed
    • PARAGON_COMPILED_THEMES_PATH β†’ where compiled theme CSS will be stored
  • Ensures folders are created during tutor plugins enable, tutor config save, etc.

  • Adds a detailed README.rst explaining the plugin's structure, purpose, configuration, and future direction

πŸ“˜ Context

This is the foundation for the Paragon theme management plugin, which will later include a build service (paragon-compiler) and a CLI task.

@openedx-webhooks
Copy link

Thanks for the pull request, @Alec4r!

This repository is currently maintained by @arbrandes.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

πŸ”˜ Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
πŸ”˜ Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
πŸ”˜ Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

πŸ’‘ As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 12, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 12, 2025
@Alec4r
Copy link
Contributor Author

Alec4r commented May 12, 2025

@brian-smith-tcril could you help me here, please?

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks like great scaffolding!

I'm not sure how much fits into this milestone (Milestone 1) vs the later milestones.

I know Milestone 3 includes hosting the generated CSS files - is there any scaffolding that should be done for that now?

I'm also not sure how much documentation should happen here.

If those are planned to be part of the future milestones that's great, and my comments about documentation can be non-blocking.

@Alec4r
Copy link
Contributor Author

Alec4r commented May 14, 2025

Overall this looks like great scaffolding!

I'm not sure how much fits into this milestone (Milestone 1) vs the later milestones.

I know Milestone 3 includes hosting the generated CSS files - is there any scaffolding that should be done for that now?

I'm also not sure how much documentation should happen here.

If those are planned to be part of the future milestones that's great, and my comments about documentation can be non-blocking.

I've added the default settings and some initial documentation to help get this project started. These will continue to evolve as we move through the next milestones.

I also incorporated several of your recommendations, thank you very much for the thoughtful review!


Themes placed in `theme-sources/` are compiled into CSS using `Paragon's theme build process <https://github.com/openedx/paragon/?tab=readme-ov-file#paragon-cli>`_. The resulting CSS files in `compiled-themes/` are intended to be served statically and can be linked using the `PARAGON_THEME_URLS` setting.

This structure is optimized for design token–based themes (see `Paragon Design Tokens <https://github.com/openedx/paragon/?tab=readme-ov-file#design-tokens>`__), but it is also flexible. If site operators need to include small amounts of additional CSS (not handled via tokens), we recommend doing so via extensions in the theme source directory, so they are included during the Paragon buildβ€”rather than manually editing the compiled output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we recommend doing so via extensions in the theme source directory

It'd be great to link out to documentation on how to use extensions. I didn't see anything about that mentioned in openedx/brand-openedx#26 or https://github.com/openedx/paragon/?tab=readme-ov-file#design-tokens, so this can wait until after those docs are written.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! I’ll add a link to the docs once they’re published. For now I’ll leave the mention as a placeholder.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions May 15, 2025
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I didn't even know it was possible to run workflows selectively, like this. Awesome!

@brian-smith-tcril brian-smith-tcril merged commit ac5f94f into openedx:main May 28, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants