-
Notifications
You must be signed in to change notification settings - Fork 11
Milestone 1: Plugin Scaffolding and Configuration Setup #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone 1: Plugin Scaffolding and Configuration Setup #33
Conversation
|
Thanks for the pull request, @Alec4r! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. π Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
π Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
π Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
π‘ As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@brian-smith-tcril could you help me here, please? |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks like great scaffolding!
I'm not sure how much fits into this milestone (Milestone 1) vs the later milestones.
I know Milestone 3 includes hosting the generated CSS files - is there any scaffolding that should be done for that now?
I'm also not sure how much documentation should happen here.
If those are planned to be part of the future milestones that's great, and my comments about documentation can be non-blocking.
I've added the default settings and some initial documentation to help get this project started. These will continue to evolve as we move through the next milestones. I also incorporated several of your recommendations, thank you very much for the thoughtful review! |
|
|
||
| Themes placed in `theme-sources/` are compiled into CSS using `Paragon's theme build process <https://github.com/openedx/paragon/?tab=readme-ov-file#paragon-cli>`_. The resulting CSS files in `compiled-themes/` are intended to be served statically and can be linked using the `PARAGON_THEME_URLS` setting. | ||
|
|
||
| This structure is optimized for design tokenβbased themes (see `Paragon Design Tokens <https://github.com/openedx/paragon/?tab=readme-ov-file#design-tokens>`__), but it is also flexible. If site operators need to include small amounts of additional CSS (not handled via tokens), we recommend doing so via extensions in the theme source directory, so they are included during the Paragon buildβrather than manually editing the compiled output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we recommend doing so via extensions in the theme source directory
It'd be great to link out to documentation on how to use extensions. I didn't see anything about that mentioned in openedx/brand-openedx#26 or https://github.com/openedx/paragon/?tab=readme-ov-file#design-tokens, so this can wait until after those docs are written.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point! Iβll add a link to the docs once theyβre published. For now Iβll leave the mention as a placeholder.
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I didn't even know it was possible to run workflows selectively, like this. Awesome!
π Description
This PR introduces the initial setup and functionality for the
tutor-contrib-paragonplugin.β Summary of changes
1.
chore: add CI workflow and local development toolingAdds a GitHub Actions CI workflow that runs only when changes are made in the plugin's directory (supports monorepo structure).
Includes local development tools:
pytestfor future test coverageMakefiletargets for development (make run-tests,make dev-requirements, etc.)2.
feat: create theme folders from config and document structureAdds logic to automatically create the following folders based on Tutor config values:
PARAGON_THEME_SOURCES_PATHβ where theme source files (Style Dictionary) are placedPARAGON_COMPILED_THEMES_PATHβ where compiled theme CSS will be storedEnsures folders are created during
tutor plugins enable,tutor config save, etc.Adds a detailed
README.rstexplaining the plugin's structure, purpose, configuration, and future directionπ Context
This is the foundation for the Paragon theme management plugin, which will later include a build service (
paragon-compiler) and a CLI task.