-
Notifications
You must be signed in to change notification settings - Fork 11
Milestone #2: Implement build-tokens CLI Command #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @Ang-m4! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@Alec4r It would be great if you could take a look at this! |
plugins/tutor-contrib-paragon/tutorparagon/templates/paragon/build/paragon-builder/Dockerfile
Outdated
Show resolved
Hide resolved
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good! I left a couple little comments but nothing major!
plugins/tutor-contrib-paragon/tutorparagon/templates/paragon/build/paragon-builder/Dockerfile
Outdated
Show resolved
Hide resolved
plugins/tutor-contrib-paragon/tutorparagon/templates/paragon/build/paragon-builder/Dockerfile
Outdated
Show resolved
Hide resolved
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for this!
|
How would I use this plugin to implement Admin Action Button: `from django.contrib import admin @admin.action(description="Mark selected Users as inactive") admin.site.unregister(User) @admin.register(User) I added the lines below to the plugin.py:
Added patches/openedx-lms-env with Yet the Action Button is not visible. Please what am I doing wrong? |
|
@Pauldic this is a closed PR and not an appropriate place to discuss a question like that. Please create a forum thread on https://discuss.openedx.org/ instead. The chances of someone in the community that understands your issue seeing it there are much higher. |
Description
This pull request introduces the initial implementation of the
paragon build-tokensCLI command within the Tutor plugin ecosystem. It leverages a lightweight Docker container and Tutor's custom job framework to facilitate the building of Paragon design tokens.Key Changes
Docker and Build Process
paragon-builder): Added a Dockerfile for the Paragon Builder, which uses a Node.js Alpine base image to install the Paragon CLI and execute theme builds.entrypoint.sh): Added a script to handle argument parsing and the theme compilation, it integrates with tutor jobs execution framework.paragon-builder-jobservice inlocal-docker-compose-jobs-servicesto run theme builds as Docker-based jobs.Command Execution
docommand (build_tokens) inplugin.pyto enable the flexible theme building via the Tutor CLI. This command supports options for source-only builds, token references, specific themes, and verbose logging.Usage Instructions
Build the Docker Image:
After installing and enabling the plugin, build the Docker image with the following command:
Run the Build Job:
Execute the build job using:
Note: A comprehensive list of available options for the
build-tokenscommand can be found in theREADME.rstfile.