-
Notifications
You must be signed in to change notification settings - Fork 11
feat(tests): add integration tests to tutor paragon plugin #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): add integration tests to tutor paragon plugin #36
Conversation
|
Thanks for the pull request, @Ang-m4! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Thanks for adding these! I'd like to get tests in for more CLI options (multiple themes, source only, etc.) to make sure we're covering everything, but overall this is looking great! |
479967e to
af0ab37
Compare
|
As we previously discussed, I’ve implemented integration tests for most of the available Paragon options, based on the underlying logic and expected functionality. I’d really appreciate your thoughts on this. Thanks so much for your attention and support! |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! We can definitely add more integration tests if we hit any snags, but this feels like a good starting set. The patterns set forth in this PR should be very easy to follow for anyone adding tests in the future!
Description
This PR introduces integration tests for the Tutor Paragon plugin, using Pytest to validate the plugin's setup and functionality. These tests ensure that the plugin is correctly installed, enabled, and operates as expected within the Tutor environment.
Key Enhancements
Logging Improvements
printstatements withlogger.infofor logging plugin installation processes. This change enhances log management and prevents interference with test output, especially when retrieving the Tutor installation root.Pytest Fixtures and Configuration
Introduced Pytest fixtures in
integration/conftest.pywith package level scope to:These fixtures ensure a consistent and isolated testing environment, adhering to Pytest's best practices for setup and teardown processes.
Helper Module
Added a
helpers.pymodule within theintegration/directory containing:Integration Test Suite
Developed integration tests within the
integration/directory to verify:plugin_setup_test.py).theme-sourcesandcompiled-themes) are created.paragon-build-tokensjob is available in Tutor's configuration.plugin_functionality_tests.py).Makefile Update
make integration-teststo streamline the execution of integration tests.Project Structure
How to Run Integration Tests
Execute the following command to run the integration tests: