Skip to content

Commit b62c490

Browse files
Merge pull request #4049 from openedx/release-23.x
sync: release-23.x to next
2 parents 7afc621 + bde1c5b commit b62c490

File tree

4 files changed

+15
-7
lines changed

4 files changed

+15
-7
lines changed

.github/workflows/release.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,19 @@ on:
55
branches:
66
- next
77
- release-*
8+
9+
permissions:
10+
contents: read # for checkout
11+
812
jobs:
913
release:
1014
name: Release
1115
runs-on: ubuntu-latest
16+
permissions:
17+
contents: write # to be able to publish a GitHub release
18+
issues: write # to be able to comment on released issues
19+
pull-requests: write # to be able to comment on released pull requests
20+
id-token: write # to enable use of OIDC for trusted publishing and npm provenance
1221
steps:
1322
- name: Checkout
1423
uses: actions/checkout@v5
@@ -35,5 +44,4 @@ jobs:
3544
- name: Release
3645
env:
3746
GITHUB_TOKEN: ${{ secrets.OPENEDX_SEMANTIC_RELEASE_GITHUB_TOKEN }}
38-
NPM_TOKEN: ${{ secrets.OPENEDX_SEMANTIC_RELEASE_NPM_TOKEN }}
39-
run: npx semantic-release@22
47+
run: npx semantic-release@25

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/IconButton/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { OverlayTrigger } from '../Overlay';
55
import Tooltip from '../Tooltip';
66
import Icon from '../Icon';
77

8-
interface Props extends React.HTMLAttributes<HTMLButtonElement> {
8+
interface Props extends React.ButtonHTMLAttributes<HTMLButtonElement> {
99
/** Component that renders the icon, currently defaults to `Icon` */
1010
iconAs?: React.ComponentType<any>,
1111
/** Additional CSS class[es] to apply to this button */

src/IconButtonToggle/index.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
44
/**
55
*
66
* @param {object} args arguments
7-
* @param {boolean} args.activeValue the current value of the active/selected iconButton.
7+
* @param {string} args.activeValue the current value of the active/selected iconButton.
88
* if not provided, none of the iconButtons will initially be active
99
* @param {Function} args.onChange callback to call when toggle value changes.
1010
* Receives value of the selected toggle button.

0 commit comments

Comments
 (0)