fix: CardImageCup stretches image on Safari

[PKulkoRaccoonGang]

Description

In Safari browser, the image inside the Card component is not stretched in height correctly.

Issue: #3187

Result in Safari

Screen.Recording.2025-02-19.at.09.07.24.mov

Merge Checklist

• If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
• Does your change adhere to the documented style conventions?
• Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
• Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
• Were your changes tested in the example app?
• Is there adequate test coverage for your changes?
• Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

• Verify your changes were released to NPM at the expected version.
• If you'd like, share your contribution in #show-and-tell.
• 🎉 🙌 Celebrate! Thanks for your contribution.

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[netlify]

✅ Deploy Preview for paragon-openedx-v22 ready!

Name	Link
🔨 Latest commit	df74a27
🔍 Latest deploy log	https://app.netlify.com/sites/paragon-openedx-v22/deploys/67f62f3df1ea6a0008dcd64a
😎 Deploy Preview	https://deploy-preview-3436--paragon-openedx-v22.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.48%. Comparing base (b0187dd) to head (df74a27).
⚠️ Report is 22 commits behind head on release-22.x.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-22.x    #3436      +/-   ##
================================================
+ Coverage         93.40%   93.48%   +0.07%     
================================================
  Files               252      252              
  Lines              4534     4557      +23     
  Branches           1064     1066       +2     
================================================
+ Hits               4235     4260      +25     
+ Misses              296      294       -2     
  Partials              3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mxzybin]

This does fix an image rendering issue in Safari, which can render images incorrectly if the width is not explicitly specified.

[mxzybin]

This does fix an image rendering issue in Safari, which can render images incorrectly if the width is not explicitly specified.

[brian-smith-tcril]

This seems to change the behavior when smaller images are used, I used https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/shiny/132.png to test but just changing the src from https://picsum.photos/360/200/ to something small like https://picsum.photos/20/20/ also reveals the issue

Left: This PR
Right: Latest 22.x

[PKulkoRaccoonGang]

This seems to change the behavior when smaller images are used, I used https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/shiny/132.png to test but just changing the src from https://picsum.photos/360/200/ to something small like https://picsum.photos/20/20/ also reveals the issue

@brian-smith-tcril thank you! I will try to find a solution that will not create additional problems for us and will work in Safari

[mxzybin]

I tested these cards in Safari. I think the most reliable way to solve the problem is to add absolute positioning to the image.
This fix resolves an image rendering issue when using max-width: inherit; width: auto; in Safari. Safari can ignore max-width: inherit and render the image to the page at its original size. Adding position: absolute takes the image out of the stream and creates a separate context for rendering the image.

[mphilbrick211]

Hi @PKulkoRaccoonGang! Is this pull request still in progress?

[PKulkoRaccoonGang]

Hi @PKulkoRaccoonGang! Is this pull request still in progress?

I moved this PR to a draft, I want to check how it works now

[mphilbrick211]

Hi @PKulkoRaccoonGang checking back in on this - is this still in progress?

[mphilbrick211]

Hi @PKulkoRaccoonGang checking back in on this - is this still in progress?

Friendly ping on this, @PKulkoRaccoonGang

[PKulkoRaccoonGang]

@mphilbrick211 thanks! I plan to return to this in the near future.