feat: add info variant to CardStatus; refactor to TypeScript#3470
feat: add info variant to CardStatus; refactor to TypeScript#3470adamstankiewicz wants to merge 2 commits intorelease-22.xfrom
Conversation
✅ Deploy Preview for paragon-openedx-v22 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-22.x #3470 +/- ##
================================================
- Coverage 93.46% 93.46% -0.01%
================================================
Files 252 252
Lines 4543 4558 +15
Branches 1023 1066 +43
================================================
+ Hits 4246 4260 +14
+ Misses 294 291 -3
- Partials 3 7 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the pull request, @adamstankiewicz! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Description
This PR, in addition to migrating
CardStatusandCardContextto TypeScript, adds official support forvariant="info"on theCard.Status:Technically, all standard Bootstrap variants are supported, but not documented or defined in the available prop type options.
[context] We likely have an upcoming use case where we'd like
Card.Statusto support theinfovariant. While it functionally works, it throws a prop type warning due to not being "officially" supported.Deploy Preview
https://deploy-preview-3470--paragon-openedx-v22.netlify.app/components/card/#card-status
Merge Checklist
exampleapp?Post-merge Checklist