Skip to content

feat: add info variant to CardStatus; refactor to TypeScript#3470

Closed
adamstankiewicz wants to merge 2 commits intorelease-22.xfrom
ags/card-status-info-variant
Closed

feat: add info variant to CardStatus; refactor to TypeScript#3470
adamstankiewicz wants to merge 2 commits intorelease-22.xfrom
ags/card-status-info-variant

Conversation

@adamstankiewicz
Copy link
Copy Markdown
Member

@adamstankiewicz adamstankiewicz commented Mar 12, 2025

Description

This PR, in addition to migrating CardStatus and CardContext to TypeScript, adds official support for variant="info" on the Card.Status:

image

Technically, all standard Bootstrap variants are supported, but not documented or defined in the available prop type options.

[context] We likely have an upcoming use case where we'd like Card.Status to support the info variant. While it functionally works, it throws a prop type warning due to not being "officially" supported.

Deploy Preview

https://deploy-preview-3470--paragon-openedx-v22.netlify.app/components/card/#card-status

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 12, 2025

Deploy Preview for paragon-openedx-v22 ready!

Name Link
🔨 Latest commit 6b3e226
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx-v22/deploys/67d1110d83a92e0008954f44
😎 Deploy Preview https://deploy-preview-3470--paragon-openedx-v22.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.46%. Comparing base (0077397) to head (6b3e226).
⚠️ Report is 19 commits behind head on release-22.x.

Files with missing lines Patch % Lines
src/Card/CardStatus.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-22.x    #3470      +/-   ##
================================================
- Coverage         93.46%   93.46%   -0.01%     
================================================
  Files               252      252              
  Lines              4543     4558      +15     
  Branches           1023     1066      +43     
================================================
+ Hits               4246     4260      +14     
+ Misses              294      291       -3     
- Partials              3        7       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @adamstankiewicz!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 5, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 5, 2026
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants