feat!: Drop the archived_by user.

We don't need that for this model, it's not that important.

Author: feanil

backend/sample_plugin/models.py

@@ -10,8 +10,9 @@ class CourseArchiveStatus(models.Model):
     """
     Model to track the archive status of a course.
 
-    Stores information about whether a course has been archived, when it was archived,
-    and who archived it.
+    Stores information about whether a course has been archived and when it was archived.
+    
+    .. no_pii: This model does not store PII directly, only references to users via foreign keys.
     """
 
     course_id = CourseKeyField(
@@ -39,15 +40,6 @@ class CourseArchiveStatus(models.Model):
         help_text="The date and time when the course was archived."
     )
 
-    archived_by = models.ForeignKey(
-        get_user_model(),
-        null=True,
-        blank=True,
-        on_delete=models.SET_NULL,
-        related_name="archived_courses",
-        help_text="The user who archived the course."
-    )
-
     created_at = models.DateTimeField(auto_now_add=True)
     updated_at = models.DateTimeField(auto_now=True)
 

backend/sample_plugin/serializers.py

@@ -22,8 +22,7 @@ class Meta:
             'user',
             'is_archived',
             'archive_date',
-            'archived_by',
             'created_at',
             'updated_at',
         ]
-        read_only_fields = ['id', 'created_at', 'updated_at', 'archive_date', 'archived_by']
+        read_only_fields = ['id', 'created_at', 'updated_at', 'archive_date']

backend/sample_plugin/views.py

@@ -90,7 +90,7 @@ def get_queryset(self):
         self._validate_query_params()
 
         # Always use select_related to avoid N+1 queries
-        base_queryset = CourseArchiveStatus.objects.select_related('user', 'archived_by')
+        base_queryset = CourseArchiveStatus.objects.select_related('user')
 
         if user.is_staff or user.is_superuser:
             return base_queryset
@@ -147,10 +147,9 @@ def perform_create(self, serializer):
             )
             raise PermissionDenied("You do not have permission to create records for other users.")
 
-        # Set archive_date and archived_by if is_archived is True
+        # Set archive_date if is_archived is True
         if data.get('is_archived', False):
             data['archive_date'] = timezone.now()
-            data['archived_by'] = self.request.user
 
         # Create the record
         instance = serializer.save(**data)
@@ -174,16 +173,14 @@ def perform_update(self, serializer):
         instance = serializer.instance
         data = serializer.validated_data.copy()
 
-        # Handle archive_date and archived_by if is_archived changes
+        # Handle archive_date if is_archived changes
         if 'is_archived' in data:
             # If changing from not archived to archived
             if data['is_archived'] and not instance.is_archived:
                 data['archive_date'] = timezone.now()
-                data['archived_by'] = self.request.user
             # If changing from archived to not archived
             elif not data['is_archived'] and instance.is_archived:
                 data['archive_date'] = None
-                data['archived_by'] = None
 
         # Update the record
         updated_instance = serializer.save(**data)

backend/tests/test_api.py

@@ -152,13 +152,11 @@ def test_create_course_archive_status(api_client, user, course_key):
     assert response.data['user'] == user.id
     assert response.data['is_archived'] is True
     assert response.data['archive_date'] is not None
-    assert response.data['archived_by'] == user.id
 
     # Verify in database
     course_archive_status = CourseArchiveStatus.objects.get(course_id=course_key, user=user)
     assert course_archive_status.is_archived is True
     assert course_archive_status.archive_date is not None
-    assert course_archive_status.archived_by == user
 
 
 @pytest.mark.django_db
@@ -197,7 +195,6 @@ def test_staff_create_course_archive_status_for_another_user(api_client, staff_u
     assert response.data['user'] == user.id
     assert response.data['is_archived'] is True
     assert response.data['archive_date'] is not None
-    assert response.data['archived_by'] == staff_user.id
 
 
 @pytest.mark.django_db
@@ -215,13 +212,11 @@ def test_update_course_archive_status(api_client, user, course_archive_status):
     assert response.status_code == status.HTTP_200_OK
     assert response.data['is_archived'] is True
     assert response.data['archive_date'] is not None
-    assert response.data['archived_by'] == user.id
 
     # Verify in database
     course_archive_status.refresh_from_db()
     assert course_archive_status.is_archived is True
     assert course_archive_status.archive_date is not None
-    assert course_archive_status.archived_by == user
 
 
 @pytest.mark.django_db
@@ -266,4 +261,3 @@ def test_staff_can_update_other_user_course_archive_status(api_client, staff_use
 
     assert response.status_code == status.HTTP_200_OK
     assert response.data['is_archived'] is True
-    assert response.data['archived_by'] == staff_user.id

backend/tests/test_models.py

@@ -64,7 +64,6 @@ def test_course_archive_status_creation(user, course_key):
     assert course_archive_status.user == user
     assert course_archive_status.is_archived is False
     assert course_archive_status.archive_date is None
-    assert course_archive_status.archived_by is None
     assert course_archive_status.created_at is not None
     assert course_archive_status.updated_at is not None