Hard-coded waffle flags checks for email and push notifications channels

[awais-ansari]

Issue

The flags SHOW_PUSH_CHANNEL and SHOW_EMAIL_CHANNEL explicitly check for the string 'true'. As a result, the Boolean value True was incorrectly treated as an "off" state due to this hard-coded check. Waffle flags should operate as Boolean values instead. It will cause any community instance that uses a Boolean value.

SHOW_PUSH_CHANNEL: process.env.SHOW_PUSH_CHANNEL === 'true'
...(getConfig().SHOW_EMAIL_CHANNEL === 'true' && { EMAIL: 'email' }),

Fix
The logic for the waffle flags in the account MFE has been corrected. If a flag is empty, missing, or not available in the config, it is now considered false. Any flag with a non-empty string value is considered true.

For Example

If SHOW_PUSH_CHANNEL = '', it will be treated as the flag being off.
If SHOW_PUSH_CHANNEL = 'true', it will be treated as the flag being on.

[awais-ansari]

openedx/frontend-app-account#1387

[farhaanbukhsh]

#31

[farhaanbukhsh]

Hey @awais-ansari just to bring visibility for this comment

I think it will be confusing if we go with the approach of removing the value possibly we should fix something like how ENABLE_ACCOUNT_DELETION is working here, what do you think? cc: @bmtcril

The approach suggested above have the advantage of being explicit about turning of the feature, this will also avoid confusion since by the nature of these toggles we expect them to be Boolean and with this approach we cause the confusion for it to have values like empty string. Let me know your opinion and thanks a lot for working in this tricky issue.

[farhaanbukhsh]

hey @awais-ansari I think you closed this issue by mistake or are we handling setting True and False value in a new issue as pointed above. 😇 cc: @ayub02