fix: lint issues

Author: navinkarkera

lti_consumer/admin.py

@@ -16,6 +16,9 @@
 
 
 class LtiConfigurationInline(admin.TabularInline):
+    """
+    Inline for the LtiConfiguration models in Lti1p3Passport.
+    """
     model = LtiConfiguration
     extra = 0
     can_delete = False

lti_consumer/api.py

@@ -49,16 +49,15 @@ def get_or_create_local_lti_config(lti_version, block, config_store=LtiConfigura
             passport.lti_1p3_tool_keyset_url = str(block.lti_1p3_tool_keyset_url)
             passport.save()
         elif (
-            passport.lti_1p3_tool_public_key != str(block.lti_1p3_tool_public_key)
-            or passport.lti_1p3_tool_keyset_url != str(block.lti_1p3_tool_keyset_url)
+            passport.lti_1p3_tool_public_key != str(block.lti_1p3_tool_public_key) or
+            passport.lti_1p3_tool_keyset_url != str(block.lti_1p3_tool_keyset_url)
         ):
             # tool public key or url has changed, we create a new passport to avoid conflicts
             # with the existing configuration
             passport = Lti1p3Passport.objects.create(
                 lti_1p3_tool_public_key=str(block.lti_1p3_tool_public_key),
                 lti_1p3_tool_keyset_url=str(block.lti_1p3_tool_keyset_url),
             )
-            from lti_consumer.plugin.compat import save_xblock  # pylint: disable=import-outside-toplevel
             block.lti_1p3_passport_id = str(passport.passport_id)
             block.save()
             save_xblock(block)

lti_consumer/lti_1p3/key_handlers.py

@@ -112,7 +112,7 @@ def validate_and_decode(self, token):
                 message = jwt.decode(
                     token,
                     key,
-                    algorithms=['RS256', 'RS512',],
+                    algorithms=['RS256', 'RS512'],
                     options={
                         'verify_signature': True,
                         'verify_aud': False

lti_consumer/lti_xblock.py

@@ -55,17 +55,16 @@
 import urllib.parse
 from collections import namedtuple
 from importlib import import_module
-import uuid
 
 import bleach
 from django.conf import settings
 from django.utils import timezone
 from web_fragments.fragment import Fragment
-
 from webob import Response
 from xblock.core import List, Scope, String, XBlock
 from xblock.fields import Boolean, Float, Integer
 from xblock.validation import ValidationMessage
+
 try:
     from xblock.utils.resources import ResourceLoader
     from xblock.utils.studio_editable import StudioEditableXBlockMixin

lti_consumer/models.py

@@ -155,7 +155,7 @@ def clean(self):
             raise ValidationError({
                 "config_store": _(
                     "LTI Configuration stored on the model for LTI 1.3 must have a value for one of "
-                        "lti_1p3_tool_public_key or lti_1p3_tool_keyset_url."
+                    "lti_1p3_tool_public_key or lti_1p3_tool_keyset_url."
                 ),
             })
 

lti_consumer/tests/unit/test_api.py

@@ -3,21 +3,21 @@
 """
 from unittest.mock import Mock, patch
 from urllib.parse import parse_qs, urlparse
-import ddt
 
+import ddt
 from Cryptodome.PublicKey import RSA
 from django.test.testcases import TestCase
 from edx_django_utils.cache import get_cache_key
 
 from lti_consumer.api import (
     _get_config_by_config_id,
-    get_or_create_local_lti_config,
     config_id_for_block,
+    get_deep_linking_data,
     get_end_assessment_return,
     get_lti_1p3_content_url,
-    get_deep_linking_data,
     get_lti_1p3_launch_info,
     get_lti_1p3_launch_start_url,
+    get_or_create_local_lti_config,
     validate_lti_1p3_launch_data,
 )
 from lti_consumer.data import Lti1p3LaunchData, Lti1p3ProctoringLaunchData
@@ -129,7 +129,7 @@ def test_store_types(self, mapping_pair, mock_external_config):
 
 
 @ddt.ddt
-class TestGetOrCreateLocalLtiConfiguration(TestCase):
+class TestGetOrCreateLocalLtiConfiguration(Lti1P3TestCase):
     """
     Unit tests for _get_or_create_local_lti_config API method.
     """
@@ -146,7 +146,7 @@ def test_create_lti_config_if_inexistent(self):
         # Call API
         lti_config = get_or_create_local_lti_config(
             lti_version=lti_version,
-            block_location=location
+            block=self.xblock
         )
 
         # Check if the object was created