update master

Author: sagemaso

CHANGELOG.md

@@ -2,6 +2,48 @@
 
 All notable changes to this project will be documented in this file.
 
+## [Unreleased]
+
+### Changed
+- Renamed rule classes to follow `*Validation` naming convention (e.g., `NotNullAndNotNaNValidation`)
+- Added `_parse_table_name()` helper for table name parsing
+- Moved `get_schema_and_table()` to base.py for reuse
+- Added `create_result()` factory method in base rule class
+- Added default values for database connection parameters
+- Updated custom rule names in HTML matrix display
+- Updated empty tables message in reports
+
+### Added
+- `WholeTableNotNullAndNotNaNValidation` rule for validating all columns automatically
+- Dynamic version display in HTML reports
+- Automatic rule initialization
+
+### Fixed
+- Directory handling for validation runs
+- Report generation issues
+
+## [1.1.1] - 2025-11-21
+
+### Changed
+- Upgraded to Python 3.10
+- Renamed `dataset` parameter to `table` in rule definitions
+- Refactored rule initialization with centralized code
+- Updated dependencies for egon-data compatibility
+- Improved Details section in HTML report
+
+### Added
+- Inline validation declaration support
+- Execution time tracking for rules
+- `__init__` methods to all validation classes
+- Logging for table count during validation
+- Report assets included in package distribution
+
+### Fixed
+- Test bugs and rule discovery issues
+- GeoAlchemy compatibility
+- Coverage test calculations
+- Return statement handling in rules
+
 ## [1.0.0] - 2025-09-29
 
 ### Added
@@ -41,11 +83,6 @@ All notable changes to this project will be documented in this file.
 - Coverage analysis for missing tables
 - Rule registration and discovery
 
-## [Unreleased]
-
-### Changed
-- Updated README.md structure and documentation
-
 ---
 
 ## Development History
@@ -141,4 +178,5 @@ All notable changes to this project will be documented in this file.
 - Add sanity rules
 - Initial project skeleton
 
+[1.1.1]: https://github.com/yourusername/egon-validation/releases/tag/v1.1.1
 [1.0.0]: https://github.com/yourusername/egon-validation/releases/tag/v1.0.0

README.md

@@ -101,15 +101,16 @@ class CapacityRangeCheck(SqlRule):
 
 | Rule | Purpose |
 |------|---------|
-| `NotNullAndNotNaN` | Validates no NULL/NaN values in one or more specified columns |
-| `WholeTableNotNullAndNotNaN` | Validates no NULL/NaN values in all table columns (auto-discovery) |
+| `NotNullAndNotNaNValidation` | Validates no NULL/NaN values in one or more specified columns |
+| `WholeTableNotNullAndNotNaNValidation` | Validates no NULL/NaN values in all table columns (auto-discovery) |
 | `DataTypeValidation` | Verifies data types for one or more columns |
-| `GeometryCheck` | PostGIS geometry validity |
-| `SRIDUniqueNonZero` | PostGIS SRID consistency |
-| `ReferentialIntegrityCheck` | Foreign key validation |
-| `RowCountCheck` | Row count boundaries |
-| `ValueSetCheck` | Enum/allowed values |
-| `ArrayCardinalityCheck` | Array length constraints |
+| `GeometryContainmentValidation` | PostGIS geometry validity and containment |
+| `SRIDUniqueNonZero` | PostGIS SRID consistency (unique, non-zero) |
+| `SRIDSpecificValidation` | PostGIS SRID validation against expected value |
+| `ReferentialIntegrityValidation` | Foreign key validation |
+| `RowCountValidation` | Row count boundaries |
+| `ValueSetValidation` | Enum/allowed values |
+| `ArrayCardinalityValidation` | Array length constraints |
 
 ## Configuration
 

egon_validation/db.py

@@ -13,16 +13,32 @@
 
 logger = get_logger("db")
 
+# Database connection pool configuration
+# Pool size matches default ThreadPoolExecutor max_workers (6) + 1 for main thread
+DEFAULT_POOL_SIZE = 7
+# Allow temporary bursts up to 10 total connections (7 + 3)
+DEFAULT_MAX_OVERFLOW = 3
+# Recycle connections after 30 minutes to prevent stale connections
+POOL_RECYCLE_SECONDS = 1800
+
 
 def make_engine(db_url: str, echo: bool = False) -> Engine:
-    """Create SQLAlchemy engine with connection pooling."""
+    """Create SQLAlchemy engine with connection pooling.
+
+    Args:
+        db_url: Database connection URL
+        echo: If True, log all SQL statements
+
+    Returns:
+        Configured SQLAlchemy Engine with connection pooling
+    """
     return create_engine(
         db_url,
         echo=echo,
-        pool_size=7,
-        max_overflow=3,
-        pool_pre_ping=True,
-        pool_recycle=1800,
+        pool_size=DEFAULT_POOL_SIZE,
+        max_overflow=DEFAULT_MAX_OVERFLOW,
+        pool_pre_ping=True,  # Verify connection health before using
+        pool_recycle=POOL_RECYCLE_SECONDS,
     )
 
 

egon_validation/report/assets/report.js

@@ -184,6 +184,17 @@
     return ruleName.substring(0, 10);
   }
 
+  // Function to create abbreviation for custom check names (underscore-separated)
+  function createCustomCheckAbbreviation(name) {
+    const words = name.split('_');
+    if (words.length > 1) {
+      // Take first letter of each word part
+      return words.map(w => w[0]).join('').toUpperCase();
+    }
+    // If no underscores, take first 4 characters
+    return name.substring(0, 4).toUpperCase();
+  }
+
   const thead = document.createElement('thead'); const hr = document.createElement('tr');
   hr.innerHTML = '<th>Schema.Table \\\\ Rule</th>' +
     rules.map(r => `<th title="${r}">${createAbbreviation(r)}</th>`).join('') + 
@@ -206,7 +217,7 @@
       rowHtml += `<td>${icon}</td>`;
     }
     const customs = (coverage.custom_checks && coverage.custom_checks[d]) ? coverage.custom_checks[d] : [];
-    const customHtml = customs.length ? customs.map(name => `<span class="tag has-tooltip clickable" title="Custom check: ${name}" data-dataset="${d}" data-rule="${name}">${name}</span>`).join('') : '<span class="badge empty">—</span>';
+    const customHtml = customs.length ? customs.map(name => `<span class="tag has-tooltip clickable" title="${name}" data-dataset="${d}" data-rule="${name}">${createCustomCheckAbbreviation(name)}</span>`).join('') : '<span class="badge empty">—</span>';
     rowHtml += `<td class="custom-cell">${customHtml}</td>`;
     tr.innerHTML = rowHtml; tbody.appendChild(tr);
   }