Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Commit 7875b78

Browse files
authored
Add deprecation warnings (#11682)
1 parent fdf5f67 commit 7875b78

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

parity/run.rs

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ use types::{
4646
use parity_rpc::{
4747
Origin, Metadata, NetworkSettings, informant, PubSubSession, FutureResult, FutureResponse, FutureOutput
4848
};
49-
use updater::{UpdatePolicy, Updater};
49+
use updater::{UpdateFilter, UpdatePolicy, Updater};
5050
use parity_version::version;
5151
use ethcore_private_tx::{ProviderConfig, EncryptorConfig, SecretStoreEncryptor};
5252
use params::{
@@ -639,10 +639,14 @@ fn execute_impl<Cr, Rr>(
639639
.map_err(|e| format!("Stratum start error: {:?}", e))?;
640640
}
641641

642-
let (private_tx_sync, private_state) = match cmd.private_tx_enabled {
643-
true => (Some(private_tx_service.clone() as Arc<dyn PrivateTxHandler>), Some(private_tx_provider.private_state_db())),
644-
false => (None, None),
645-
};
642+
let mut private_tx_sync = None;
643+
let mut private_state = None;
644+
645+
if cmd.private_tx_enabled {
646+
warn!("Private transactions support is deprecated and may be removed in a future release. e. Please see #11695 for details:\nhttps://github.com/openethereum/openethereum/issues/11695");
647+
private_tx_sync = Some(private_tx_service.clone() as Arc<dyn PrivateTxHandler>);
648+
private_state = Some(private_tx_provider.private_state_db());
649+
}
646650

647651
// create sync object
648652
let (sync_provider, manage_network, chain_notify, priority_tasks) = modules::sync(
@@ -699,6 +703,10 @@ fn execute_impl<Cr, Rr>(
699703
);
700704

701705
// the updater service
706+
if update_policy.filter != UpdateFilter::None {
707+
warn!("Updater is deprecated and may be removed in a future release. e. Please see #11696 for details:\nhttps://github.com/openethereum/openethereum/issues/11696");
708+
}
709+
702710
let updater = Updater::new(
703711
&Arc::downgrade(&(service.client() as Arc<dyn BlockChainClient>)),
704712
&Arc::downgrade(&sync_provider),
@@ -925,6 +933,7 @@ pub fn execute<Cr, Rr>(
925933
Rr: Fn() + 'static + Send
926934
{
927935
if cmd.light {
936+
warn!("Light client is deprecated and may be removed in a future release. Please see #11681 for details:\nhttps://github.com/openethereum/openethereum/issues/11681");
928937
execute_light_impl(cmd, logger, on_client_rq)
929938
} else {
930939
execute_impl(cmd, logger, on_client_rq, on_updater_rq)

0 commit comments

Comments
 (0)