Fix type conversion in gateway version on nil

Signed-off-by: Alistair Hey <[email protected]>

Author: Waterdrips

commands/version.go

@@ -152,9 +152,18 @@ func printLogo() {
 func getGatewayDetails(m map[string]interface{}) (version, sha, commit string) {
 	if _, ok := m["orchestration"]; !ok {
 		v := m["version"].(map[string]interface{})
-		version = v["release"].(string)
-		sha = v["sha"].(string)
-		commit = v["commit_message"].(string)
+		version, ok = v["release"].(string)
+		if !ok {
+			version = ""
+		}
+		sha, ok = v["sha"].(string)
+		if !ok {
+			sha = ""
+		}
+		commit, ok = v["commit_message"].(string)
+		if !ok {
+			commit = ""
+		}
 	}
 
 	return
@@ -184,10 +193,22 @@ func getProviderDetailsLegacy(m map[string]interface{}) (name, orchestration, sh
 
 func getProviderDetailsCurrent(m map[string]interface{}) (name, orchestration, sha, version string) {
 	v := m["version"].(map[string]interface{})
-	version = v["release"].(string)
-	sha = v["sha"].(string)
-	name = m["provider"].(string)
-	orchestration = m["orchestration"].(string)
+	version, ok := v["release"].(string)
+	if !ok {
+		version = ""
+	}
+	sha, ok = v["sha"].(string)
+	if !ok {
+		sha = ""
+	}
+	name, ok = m["provider"].(string)
+	if !ok {
+		name = ""
+	}
+	orchestration, ok = m["orchestration"].(string)
+	if !ok {
+		orchestration = ""
+	}
 
 	return
 }

commands/version_test.go

@@ -99,6 +99,21 @@ func Test_gateway_and_provider_information(t *testing.T) {
 				{"provider sha", "sha:           c890cba302d059de8edbef3f3de7fe15444b1ecf"},
 			},
 		},
+		{
+			responseBody: gateway_response_0_8_4_onwards_nil_values,
+			params: []struct {
+				name  string
+				value string
+			}{
+				{"gateway version", "version: "},
+				{"gateway sha", "sha:     "},
+				{"gateway commit", "commit:  "},
+				{"provider name", "name:          "},
+				{"provider orchestration", "orchestration: "},
+				{"provider version", "version:       "},
+				{"provider sha", "sha:           "},
+			},
+		},
 		{
 			responseBody: gateway_response_prior_to_0_8_4,
 			params: []struct {
@@ -199,6 +214,15 @@ const gateway_response_0_8_4_onwards = `{
   } 
 }`
 
+const gateway_response_0_8_4_onwards_nil_values = `{
+  "provider": {
+    "version": {
+    }
+  },
+  "version": {
+  } 
+}`
+
 const gateway_response_prior_to_0_8_4 = `{
   "provider": "faas-swarm",
   "version": {