Skip to content

Commit 4149ade

Browse files
committed
Update default gateway to gateway.openfaas
Fixes #178 thanks to @jenoOvchi Closes invalid PR: #179 Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
1 parent c50465b commit 4149ade

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

issue-bot-secrets/bot-handler/handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def handle(req):
99
sys.exit(1)
1010
return
1111

12-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
12+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
1313

1414
payload = json.loads(req)
1515

issue-bot/bot-handler/handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def handle(req):
88
sys.exit("Unable to handle X-GitHub-Event: " + event_header)
99
return
1010

11-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
11+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
1212

1313
payload = json.loads(req)
1414

lab4.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ Suffix the gateway host with `openfaas` namespace:
372372
Or via an environmental variable:
373373

374374
```python
375-
gateway_hostname = os.getenv("gateway_hostname", "gateway") # uses a default of "gateway" for when "gateway_hostname" is not set
375+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas") # uses a default of "gateway.openfaas" for when "gateway_hostname" is not set
376376
test_sentence = "California is great, it's always sunny there."
377377
r = requests.get("http://" + gateway_hostname + ":8080/function/sentimentanalysis", data= test_sentence)
378378
```
@@ -400,7 +400,7 @@ def handle(req):
400400
req (str): request body
401401
"""
402402
403-
gateway_hostname = os.getenv("gateway_hostname", "gateway") # uses a default of "gateway" for when "gateway_hostname" is not set
403+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas") # uses a default of "gateway" for when "gateway_hostname" is not set
404404
405405
test_sentence = req
406406

lab5.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ def handle(req):
204204
sys.exit("Unable to handle X-GitHub-Event: " + event_header)
205205
return
206206

207-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
207+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
208208

209209
payload = json.loads(req)
210210

@@ -345,7 +345,7 @@ def handle(req):
345345
sys.exit("Unable to handle X-GitHub-Event: " + event_header)
346346
return
347347
348-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
348+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
349349
350350
payload = json.loads(req)
351351

translations/ja/lab4.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ $ echo -n "California is great, it's always sunny there." | faas-cli invoke sent
230230
また、環境変数を使った場合は次のようになります:
231231

232232
```python
233-
gateway_hostname = os.getenv("gateway_hostname", "gateway") # gateway_hostnameという環境変数が無い場合はデフォルト値の"gateway"に設定
233+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas") # gateway_hostnameという環境変数が無い場合はデフォルト値の"gateway"に設定
234234
test_sentence = "California is great, it's always sunny there."
235235
r = requests.get("http://" + gateway_hostname + ":8080/function/sentimentanalysis", text= test_sentence)
236236
```
@@ -258,7 +258,7 @@ def handle(req):
258258
req (str): request body
259259
"""
260260

261-
gateway_hostname = os.getenv("gateway_hostname", "gateway") # gateway_hostnameという環境変数が無い場合はデフォルト値の"gateway"に設定
261+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas") # gateway_hostnameという環境変数が無い場合はデフォルト値の"gateway"に設定
262262

263263
test_sentence = req
264264

translations/ja/lab5.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def handle(req):
146146
sys.exit("Unable to handle X-GitHub-Event: " + event_header)
147147
return
148148

149-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
149+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
150150

151151
payload = json.loads(req)
152152

@@ -279,7 +279,7 @@ def handle(req):
279279
sys.exit("Unable to handle X-GitHub-Event: " + event_header)
280280
return
281281
282-
gateway_hostname = os.getenv("gateway_hostname", "gateway")
282+
gateway_hostname = os.getenv("gateway_hostname", "gateway.openfaas")
283283
284284
payload = json.loads(req)
285285

0 commit comments

Comments
 (0)