Skip to content

Commit 315a93c

Browse files
authored
[Android] Phase out older ARM architectures (#1928)
2 parents 6acb0cb + a4b4fca commit 315a93c

File tree

2 files changed

+3
-20
lines changed

2 files changed

+3
-20
lines changed

include.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@
115115
<define name="MACOSX_DEPLOYMENT_TARGET" value="10.9" if="mac" unless="MACOSX_DEPLOYMENT_TARGET" />
116116
<setenv name="MACOSX_DEPLOYMENT_TARGET" value="${MACOSX_DEPLOYMENT_TARGET}" if="mac" />
117117

118-
<architecture name="armv7" if="android" />
119-
120118
<section if="emscripten">
121119

122120
<dependency name="pthread" />

tools/platforms/AndroidPlatform.hx

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -135,16 +135,13 @@ class AndroidPlatform extends PlatformTarget
135135
var hxml = targetDirectory + "/haxe/" + buildType + ".hxml";
136136
var sourceSet = destination + "/app/src/main";
137137

138-
var hasARMV5 = (ArrayTools.containsValue(project.architectures, Architecture.ARMV5)
139-
|| ArrayTools.containsValue(project.architectures, Architecture.ARMV6));
140138
var hasARMV7 = ArrayTools.containsValue(project.architectures, Architecture.ARMV7);
141139
var hasARM64 = ArrayTools.containsValue(project.architectures, Architecture.ARM64);
142140
var hasX86 = ArrayTools.containsValue(project.architectures, Architecture.X86);
143141
var hasX64 = ArrayTools.containsValue(project.architectures, Architecture.X64);
144142

145143
var architectures = [];
146144

147-
if (hasARMV5) architectures.push(Architecture.ARMV5);
148145
if (hasARMV7) architectures.push(Architecture.ARMV7);
149146
if (hasARM64) architectures.push(Architecture.ARM64);
150147
if (hasX86) architectures.push(Architecture.X86);
@@ -164,7 +161,7 @@ class AndroidPlatform extends PlatformTarget
164161
var minSDKVer = project.config.getInt("android.minimum-sdk-version", 21);
165162
var haxeParams = [hxml, "-D", "android", "-D", 'PLATFORM_NUMBER=$minSDKVer'];
166163
var cppParams = ["-Dandroid", '-DPLATFORM_NUMBER=$minSDKVer'];
167-
var path = sourceSet + "/jniLibs/armeabi";
164+
var path = sourceSet + "/jniLibs/";
168165
var suffix = ".so";
169166

170167
if (architecture == Architecture.ARMV7)
@@ -214,14 +211,6 @@ class AndroidPlatform extends PlatformTarget
214211
System.copyIfNewer(targetDirectory + "/obj/libApplicationMain" + (project.debug ? "-debug" : "") + suffix, path + "/libApplicationMain.so");
215212
}
216213

217-
if (!hasARMV5)
218-
{
219-
if (FileSystem.exists(sourceSet + "/jniLibs/armeabi"))
220-
{
221-
System.removeDirectory(sourceSet + "/jniLibs/armeabi");
222-
}
223-
}
224-
225214
if (!hasARMV7)
226215
{
227216
if (FileSystem.exists(sourceSet + "/jniLibs/armeabi-v7a"))
@@ -364,19 +353,15 @@ class AndroidPlatform extends PlatformTarget
364353

365354
public override function rebuild():Void
366355
{
367-
var armv5 = (/*command == "rebuild" ||*/
368-
ArrayTools.containsValue(project.architectures, Architecture.ARMV5)
369-
|| ArrayTools.containsValue(project.architectures, Architecture.ARMV6));
370-
var armv7 = (command == "rebuild" || ArrayTools.containsValue(project.architectures, Architecture.ARMV7));
356+
var armv7 = ArrayTools.containsValue(project.architectures, Architecture.ARMV7);
371357
var arm64 = (command == "rebuild" || ArrayTools.containsValue(project.architectures, Architecture.ARM64));
372-
var x86 = (ArrayTools.containsValue(project.architectures, Architecture.X86));
358+
var x86 = ArrayTools.containsValue(project.architectures, Architecture.X86);
373359
var x64 = (command == "rebuild" || ArrayTools.containsValue(project.architectures, Architecture.X64));
374360

375361
var commands = [];
376362
var minSDKVer = 21;
377363
var platformDefine = '-DPLATFORM_NUMBER=$minSDKVer';
378364

379-
if (armv5) commands.push(["-Dandroid", platformDefine]);
380365
if (armv7) commands.push(["-Dandroid", "-DHXCPP_ARMV7", platformDefine]);
381366
if (arm64) commands.push(["-Dandroid", "-DHXCPP_ARM64", platformDefine]);
382367
if (x86) commands.push(["-Dandroid", "-DHXCPP_X86", platformDefine]);

0 commit comments

Comments
 (0)