fix more implicit Dynamic variable types by explicitly declaring a type

These variables were being initialized with null, weren't initialized at all, or were initialized with an empty array, all of which introduce Dynamic

Author: joshtynjala

src/lime/_internal/backend/html5/HTML5HTTPRequest.hx

@@ -308,7 +308,8 @@ class HTML5HTTPRequest
 		if (parent.enableResponseHeaders)
 		{
 			parent.responseHeaders = [];
-			var name, value;
+			var name:String;
+			var value:String;
 
 			for (line in request.getAllResponseHeaders().split("\n"))
 			{

src/lime/_internal/backend/html5/HTML5Window.hx

@@ -482,7 +482,8 @@ class HTML5Window
 	private function handleCutOrCopyEvent(event:ClipboardEvent):Void
 	{
 		var text = Clipboard.text;
-		if (text == null) {
+		if (text == null)
+		{
 			text = "";
 		}
 		event.clipboardData.setData("text/plain", text);
@@ -705,7 +706,6 @@ class HTML5Window
 					}
 
 				case "mouseup":
-
 					// see comment below for mousemove for an explanation of
 					// what the __stopMousePropagation flag is used for.
 					if (__stopMousePropagation && event.currentTarget != parent.element)
@@ -729,7 +729,6 @@ class HTML5Window
 					}
 
 				case "mousemove":
-
 					// this same listener is added to the parent element and to
 					// the browser window for both the mousemove and the mouseup
 					// event types, if mousedown happens first. this allows both
@@ -866,7 +865,11 @@ class HTML5Window
 			}
 		}
 
-		var touch, x, y, cacheX, cacheY;
+		var touch:Touch;
+		var x:Float;
+		var y:Float;
+		var cacheX:Float;
+		var cacheY:Float;
 
 		for (data in event.changedTouches)
 		{
@@ -1300,7 +1303,6 @@ class HTML5Window
 				textInput.removeEventListener('paste', handlePasteEvent, true);
 				textInput.removeEventListener('compositionstart', handleCompositionstartEvent, true);
 				textInput.removeEventListener('compositionend', handleCompositionendEvent, true);
-
 			}
 		}
 
@@ -1344,7 +1346,8 @@ class HTML5Window
 	{
 		if (!parent.__resizable) return;
 
-		var elementWidth, elementHeight;
+		var elementWidth:Float;
+		var elementHeight:Float;
 
 		if (parent.element != null)
 		{
@@ -1370,8 +1373,8 @@ class HTML5Window
 				{
 					if (parent.__width != elementWidth || parent.__height != elementHeight)
 					{
-						parent.__width = elementWidth;
-						parent.__height = elementHeight;
+						parent.__width = Std.int(elementWidth);
+						parent.__height = Std.int(elementHeight);
 
 						if (canvas != null)
 						{
@@ -1390,7 +1393,7 @@ class HTML5Window
 							div.style.height = elementHeight + "px";
 						}
 
-						parent.onResize.dispatch(elementWidth, elementHeight);
+						parent.onResize.dispatch(Std.int(elementWidth), Std.int(elementHeight));
 					}
 				}
 				else

src/lime/_internal/backend/native/NativeWindow.hx

@@ -350,7 +350,10 @@ class NativeWindow
 				var windowWidth = Std.int(parent.__width * parent.__scale);
 				var windowHeight = Std.int(parent.__height * parent.__scale);
 
-				var x, y, width, height;
+				var x:Int;
+				var y:Int;
+				var width:Int;
+				var height:Int;
 
 				if (rect != null)
 				{

src/lime/_internal/format/BMP.hx

@@ -109,7 +109,10 @@ class BMP
 
 		var pixels = image.getPixels(new Rectangle(0, 0, image.width, image.height), ARGB32);
 		var readPosition = 0;
-		var a, r, g, b;
+		var a:Int;
+		var r:Int;
+		var g:Int;
+		var b:Int;
 
 		switch (type)
 		{

src/lime/_internal/graphics/ImageCanvasUtil.hx

@@ -223,7 +223,10 @@ class ImageCanvasUtil
 	{
 		convertToCanvas(image);
 
-		var r, g, b, a;
+		var r:Int;
+		var g:Int;
+		var b:Int;
+		var a:Int;
 
 		if (format == ARGB32)
 		{

src/lime/_internal/graphics/ImageDataUtil.hx

@@ -327,8 +327,12 @@ class ImageDataUtil
 				var sourceFormat = sourceImage.buffer.format;
 				var destFormat = image.buffer.format;
 
-				var sourcePosition, destPosition;
-				var sourceAlpha, destAlpha, oneMinusSourceAlpha, blendAlpha;
+				var sourcePosition:Int;
+				var destPosition:Int;
+				var sourceAlpha:Float;
+				var destAlpha:Float;
+				var oneMinusSourceAlpha:Float;
+				var blendAlpha:Float;
 				var sourcePixel:RGBA = 0;
 				var destPixel:RGBA = 0;
 
@@ -694,7 +698,8 @@ class ImageDataUtil
 			_mask.a = 0xFF;
 		}
 
-		var pixel, hit;
+		var pixel:Int;
+		var hit:Bool;
 
 		for (x in 0...image.width)
 		{
@@ -921,7 +926,8 @@ class ImageDataUtil
 			var sourcePremultiplied = sourceImage.buffer.premultiplied;
 			var destPremultiplied = image.buffer.premultiplied;
 
-			var sourcePosition, destPosition;
+			var sourcePosition:Int;
+			var destPosition:Int;
 			var sourcePixel:RGBA = 0;
 			var destPixel:RGBA = 0;
 
@@ -1113,10 +1119,20 @@ class ImageDataUtil
 		else
 		#end
 		{
-			var index, a16;
+			var index:Int;
 			var length = Std.int(data.length / 4);
-			var r1, g1, b1, a1, r2, g2, b2, a2;
-			var r, g, b, a;
+			var r1:Int;
+			var g1:Int;
+			var b1:Int;
+			var a1:Int;
+			var r2:Int;
+			var g2:Int;
+			var b2:Int;
+			var a2:Int;
+			var r:Int;
+			var g:Int;
+			var b:Int;
+			var a:Int;
 
 			switch (image.format)
 			{
@@ -1451,7 +1467,12 @@ class ImageDataUtil
 	private static #if cpp inline #end function __boxBlurH(imgA:UInt8Array, imgB:UInt8Array, w:Int, h:Int, r:Int, off:Int):Void
 	{
 		var iarr = 1 / (r + r + 1);
-		var ti, li, ri, fv, lv, val;
+		var ti:Int;
+		var li:Int;
+		var ri:Int;
+		var fv:Int;
+		var lv:Int;
+		var val:Int;
 
 		for (i in 0...h)
 		{
@@ -1499,7 +1520,12 @@ class ImageDataUtil
 	{
 		var iarr = 1 / (r + r + 1);
 		var ws = w * 4;
-		var ti, li, ri, fv, lv, val;
+		var ti:Int;
+		var li:Int;
+		var ri:Int;
+		var fv:Int;
+		var lv:Int;
+		var val:Int;
 
 		for (i in 0...w)
 		{

src/lime/graphics/Image.hx

@@ -1594,7 +1594,6 @@ class Image
 
 				var data = new UInt8Array(Bytes.ofData(data.getData()));
 				var length = header.width * header.height;
-				var b, g, r, a;
 
 				for (i in 0...length)
 				{

src/lime/text/Font.hx

@@ -437,7 +437,8 @@ class Font
 			var offsetY = 0;
 			var maxRows = 0;
 
-			var width, height;
+			var width:Int;
+			var height:Int;
 			var i = 0;
 
 			while (i < count)
@@ -499,7 +500,10 @@ class Font
 			offsetY = 0;
 			maxRows = 0;
 
-			var index, x, y, image;
+			var index:Int;
+			var x:Int;
+			var y:Int;
+			var image:Image;
 
 			for (i in 0...count)
 			{
@@ -665,7 +669,8 @@ class Font
 			var timeout = 3000;
 			var intervalLength = 50;
 			var intervalCount = 0;
-			var loaded, timeExpired;
+			var loaded:Bool;
+			var timeExpired:Bool;
 
 			var checkFont = function()
 			{

src/lime/tools/AIRHelper.hx

@@ -92,7 +92,7 @@ class AIRHelper
 			default:
 		}
 
-		var signingOptions = [];
+		var signingOptions:Array<String> = [];
 
 		if (project.keystore != null)
 		{
@@ -406,8 +406,8 @@ class AIRHelper
 		if (targetPlatform == ANDROID && !project.targetFlags.exists("air-simulator"))
 		{
 			AndroidHelper.initialize(project);
-			var deviceID = null;
-			var adbFilter = null;
+			var deviceID:String = null;
+			var adbFilter:String = null;
 
 			// if (!Log.verbose) {
 
@@ -431,7 +431,7 @@ class AIRHelper
 		if (targetPlatform == ANDROID)
 		{
 			AndroidHelper.initialize(project);
-			var deviceID = null;
+			var deviceID:String = null;
 			AndroidHelper.uninstall(project.meta.packageName, deviceID);
 		}
 	}

src/lime/tools/AssetHelper.hx

@@ -115,7 +115,7 @@ class AssetHelper
 			libraries[lib.name] = lib;
 		}
 
-		var assetData;
+		var assetData:Dynamic;
 
 		for (asset in project.assets)
 		{
@@ -155,8 +155,8 @@ class AssetHelper
 			}
 		}
 
-		var manifest = null;
-		var manifests = [];
+		var manifest:AssetManifest = null;
+		var manifests:Array<AssetManifest> = [];
 
 		if (!hasManifest.exists(DEFAULT_LIBRARY_NAME))
 		{
@@ -178,7 +178,7 @@ class AssetHelper
 		if (targetDirectory != null)
 		{
 			System.mkdir(targetDirectory);
-			var targetPath;
+			var targetPath:String;
 
 			for (manifest in manifests)
 			{
@@ -409,7 +409,7 @@ class AssetHelper
 			libraryMap[library.name] = true;
 		}
 
-		var library;
+		var library:Library;
 
 		for (asset in project.assets)
 		{
@@ -435,7 +435,7 @@ class AssetHelper
 
 		var handlers = new Array<String>();
 		var hasPackedLibraries = false;
-		var type;
+		var type:String;
 
 		for (library in project.libraries)
 		{
@@ -492,7 +492,7 @@ class AssetHelper
 				}
 				catch (e:Dynamic)
 				{
-					var types = [];
+					var types:Array<String> = [];
 
 					for (library in project.libraries)
 					{
@@ -545,7 +545,9 @@ class AssetHelper
 			project.haxedefs.set("disable_preloader_assets", "1");
 		}
 
-		var manifest, embed, asset;
+		var manifest:AssetManifest;
+		var embed:Bool;
+		var asset:Asset;
 
 		for (library in project.libraries)
 		{
@@ -609,7 +611,10 @@ class AssetHelper
 
 	public static function processPackedLibraries(project:HXProject, targetDirectory:String = null):Void
 	{
-		var type, asset, cacheAvailable, cacheDirectory, filename;
+		var type:String;
+		var cacheAvailable:Bool;
+		var cacheDirectory:String;
+		var filename:String;
 		var output, manifest, position, assetData:Dynamic, input;
 		var embeddedLibrary = false;
 
@@ -656,7 +661,7 @@ class AssetHelper
 
 					try
 					{
-						var assetData;
+						var assetData:Dynamic;
 
 						for (asset in project.assets)
 						{